linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: willy@infradead.org (Matthew Wilcox)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 4/7] Protectable Memory
Date: Mon, 12 Mar 2018 12:13:15 -0700	[thread overview]
Message-ID: <20180312191314.GA29191@bombadil.infradead.org> (raw)
In-Reply-To: <20180228200620.30026-5-igor.stoppa@huawei.com>

On Wed, Feb 28, 2018 at 10:06:17PM +0200, Igor Stoppa wrote:
> struct gen_pool *pmalloc_create_pool(const char *name,
> 					 int min_alloc_order);
> int is_pmalloc_object(const void *ptr, const unsigned long n);
> bool pmalloc_prealloc(struct gen_pool *pool, size_t size);
> void *pmalloc(struct gen_pool *pool, size_t size, gfp_t gfp);
> static inline void *pzalloc(struct gen_pool *pool, size_t size, gfp_t gfp)
> static inline void *pmalloc_array(struct gen_pool *pool, size_t n,
> 				  size_t size, gfp_t flags)
> static inline void *pcalloc(struct gen_pool *pool, size_t n,
> 			    size_t size, gfp_t flags)
> static inline char *pstrdup(struct gen_pool *pool, const char *s, gfp_t gfp)
> int pmalloc_protect_pool(struct gen_pool *pool);
> static inline void pfree(struct gen_pool *pool, const void *addr)
> int pmalloc_destroy_pool(struct gen_pool *pool);

Do you have users for all these functions?  I'm particularly sceptical of
pfree().  To my mind, a user wants to:

pmalloc_create();
pmalloc(); * N
pmalloc_protect();
...
pmalloc_destroy();

I don't mind the pstrdup, pcalloc, pmalloc_array, pzalloc variations, but
I don't know why you need is_pmalloc_object().
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-03-12 19:13 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-28 20:06 [RFC PATCH v18 0/7] mm: security: ro protection for dynamic data Igor Stoppa
2018-02-28 20:06 ` [PATCH 1/7] genalloc: track beginning of allocations Igor Stoppa
2018-03-02 16:37   ` kbuild test robot
2018-03-02 16:47   ` kbuild test robot
2018-03-05 19:00   ` J Freyensee
2018-03-06 17:39     ` Igor Stoppa
2018-03-06 13:19   ` Mike Rapoport
2018-03-06 14:13     ` Matthew Wilcox
2018-03-07 14:48     ` Igor Stoppa
2018-03-07 15:46       ` Igor Stoppa
2018-03-07 17:44       ` Mike Rapoprt
2018-03-06 14:10   ` Matthew Wilcox
2018-03-06 16:05     ` Igor Stoppa
2018-03-07 10:51       ` Igor Stoppa
2018-02-28 20:06 ` [PATCH 2/7] genalloc: selftest Igor Stoppa
2018-03-05 19:37   ` J Freyensee
2018-02-28 20:06 ` [PATCH 3/7] struct page: add field for vm_struct Igor Stoppa
2018-03-03  2:35   ` kbuild test robot
2018-03-05 20:31   ` J Freyensee
2018-02-28 20:06 ` [PATCH 4/7] Protectable Memory Igor Stoppa
2018-03-06  3:59   ` J Freyensee
2018-03-07 14:07     ` Igor Stoppa
2018-03-12 19:13   ` Matthew Wilcox [this message]
2018-03-12 21:25     ` Igor Stoppa
2018-02-28 20:06 ` [PATCH 5/7] Pmalloc selftest Igor Stoppa
2018-03-06 17:13   ` J Freyensee
2018-02-28 20:06 ` [PATCH 6/7] lkdtm: crash on overwriting protected pmalloc var Igor Stoppa
2018-03-06 17:20   ` J Freyensee
2018-03-07 13:18     ` Igor Stoppa
2018-03-07 17:26       ` J Freyensee
2018-02-28 20:06 ` [PATCH 7/7] Documentation for Pmalloc Igor Stoppa
2018-03-06 13:30   ` Mike Rapoport
2018-03-06 17:33   ` J Freyensee
  -- strict thread matches above, loose matches on Subject: below --
2018-02-23 14:48 [RFC PATCH v17 0/7] mm: security: ro protection for dynamic data Igor Stoppa
2018-02-23 14:48 ` [PATCH 4/7] Protectable Memory Igor Stoppa
2018-02-24  0:10   ` J Freyensee
2018-02-26 14:28     ` Igor Stoppa
2018-02-26 18:25       ` J Freyensee
2018-02-25  2:33   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180312191314.GA29191@bombadil.infradead.org \
    --to=willy@infradead.org \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).