From: tycho@tycho.ws (Tycho Andersen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 1/3] big key: get rid of stack array allocation
Date: Tue, 24 Apr 2018 08:51:04 -0600 [thread overview]
Message-ID: <20180424145104.GC3125@cisco> (raw)
In-Reply-To: <201804242346.FHI69745.SQMHFVOOFLFOJt@I-love.SAKURA.ne.jp>
On Tue, Apr 24, 2018 at 11:46:38PM +0900, Tetsuo Handa wrote:
> Tycho Andersen wrote:
> > > > + if (unlikely(crypto_aead_ivsize(big_key_aead) != GCM_AES_IV_SIZE)) {
> > > > + WARN(1, "big key algorithm changed?");
>
> Please avoid using WARN() WARN_ON() etc.
> syzbot would catch it and panic() due to panic_on_warn == 1.
But it is really a programming bug in this case (and it seems better
than BUG()...). Isn't this exactly the sort of case we want to catch?
Tycho
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-04-24 14:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 1:03 [PATCH 1/3] big key: get rid of stack array allocation Tycho Andersen
2018-04-24 1:03 ` [PATCH 2/3] dh key: get rid of stack allocated array Tycho Andersen
2018-04-24 1:03 ` [PATCH 3/3] dh key: get rid of stack allocated array for zeroes Tycho Andersen
2018-04-24 3:13 ` Tycho Andersen
2018-04-24 4:50 ` [PATCH 1/3] big key: get rid of stack array allocation Eric Biggers
2018-04-24 14:35 ` Tycho Andersen
2018-04-24 14:46 ` Tetsuo Handa
2018-04-24 14:51 ` Tycho Andersen [this message]
2018-04-24 19:58 ` Serge E. Hallyn
2018-04-24 20:04 ` Kees Cook
2018-04-25 10:36 ` Tetsuo Handa
2018-04-25 14:15 ` Tycho Andersen
2018-04-24 20:09 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424145104.GC3125@cisco \
--to=tycho@tycho.ws \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).