* [PATCH v1] security/capabilities: remove check for -EINVAL
@ 2018-08-22 11:52 Christian Brauner
2018-08-22 13:58 ` Serge E. Hallyn
2018-08-29 16:09 ` James Morris
0 siblings, 2 replies; 4+ messages in thread
From: Christian Brauner @ 2018-08-22 11:52 UTC (permalink / raw)
To: linux-security-module
bprm_caps_from_vfs_caps() never returned -EINVAL so remove the
rc == -EINVAL check.
Signed-off-by: Christian Brauner <christian@brauner.io>
---
v0 -> v1
- non-functional changes:
adapt commit message to reflect the fact that
bprm_caps_from_vfs_caps() never actuall returned -EINVAL.
---
security/commoncap.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/security/commoncap.c b/security/commoncap.c
index f4c33abd9959..6012f0cd8157 100644
--- a/security/commoncap.c
+++ b/security/commoncap.c
@@ -684,9 +684,6 @@ static int get_file_caps(struct linux_binprm *bprm, bool *effective, bool *has_f
}
rc = bprm_caps_from_vfs_caps(&vcaps, bprm, effective, has_fcap);
- if (rc == -EINVAL)
- printk(KERN_NOTICE "%s: cap_from_disk returned %d for %s\n",
- __func__, rc, bprm->filename);
out:
if (rc)
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v1] security/capabilities: remove check for -EINVAL
2018-08-22 11:52 [PATCH v1] security/capabilities: remove check for -EINVAL Christian Brauner
@ 2018-08-22 13:58 ` Serge E. Hallyn
2018-08-23 16:48 ` James Morris
2018-08-29 16:09 ` James Morris
1 sibling, 1 reply; 4+ messages in thread
From: Serge E. Hallyn @ 2018-08-22 13:58 UTC (permalink / raw)
To: linux-security-module
Quoting Christian Brauner (christian at brauner.io):
> bprm_caps_from_vfs_caps() never returned -EINVAL so remove the
> rc == -EINVAL check.
>
> Signed-off-by: Christian Brauner <christian@brauner.io>
Thanks.
Reviewed-by: Serge Hallyn <serge@hallyn.com>
> ---
> v0 -> v1
> - non-functional changes:
> adapt commit message to reflect the fact that
> bprm_caps_from_vfs_caps() never actuall returned -EINVAL.
> ---
> security/commoncap.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/security/commoncap.c b/security/commoncap.c
> index f4c33abd9959..6012f0cd8157 100644
> --- a/security/commoncap.c
> +++ b/security/commoncap.c
> @@ -684,9 +684,6 @@ static int get_file_caps(struct linux_binprm *bprm, bool *effective, bool *has_f
> }
>
> rc = bprm_caps_from_vfs_caps(&vcaps, bprm, effective, has_fcap);
> - if (rc == -EINVAL)
> - printk(KERN_NOTICE "%s: cap_from_disk returned %d for %s\n",
> - __func__, rc, bprm->filename);
>
> out:
> if (rc)
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1] security/capabilities: remove check for -EINVAL
2018-08-22 13:58 ` Serge E. Hallyn
@ 2018-08-23 16:48 ` James Morris
0 siblings, 0 replies; 4+ messages in thread
From: James Morris @ 2018-08-23 16:48 UTC (permalink / raw)
To: linux-security-module
On Wed, 22 Aug 2018, Serge E. Hallyn wrote:
> Quoting Christian Brauner (christian at brauner.io):
> > bprm_caps_from_vfs_caps() never returned -EINVAL so remove the
> > rc == -EINVAL check.
> >
> > Signed-off-by: Christian Brauner <christian@brauner.io>
>
> Thanks.
>
> Reviewed-by: Serge Hallyn <serge@hallyn.com>
Thanks, I'll queue this for post -rc1 next-general.
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1] security/capabilities: remove check for -EINVAL
2018-08-22 11:52 [PATCH v1] security/capabilities: remove check for -EINVAL Christian Brauner
2018-08-22 13:58 ` Serge E. Hallyn
@ 2018-08-29 16:09 ` James Morris
1 sibling, 0 replies; 4+ messages in thread
From: James Morris @ 2018-08-29 16:09 UTC (permalink / raw)
To: linux-security-module
On Wed, 22 Aug 2018, Christian Brauner wrote:
> bprm_caps_from_vfs_caps() never returned -EINVAL so remove the
> rc == -EINVAL check.
>
> Signed-off-by: Christian Brauner <christian@brauner.io>
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-29 16:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-22 11:52 [PATCH v1] security/capabilities: remove check for -EINVAL Christian Brauner
2018-08-22 13:58 ` Serge E. Hallyn
2018-08-23 16:48 ` James Morris
2018-08-29 16:09 ` James Morris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).