From: fw@strlen.de (Florian Westphal)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v2 1/2] netfilter: nf_tables: add SECMARK support
Date: Sun, 23 Sep 2018 17:41:29 +0200 [thread overview]
Message-ID: <20180923154129.ht55keytmgxcnl73@breakpoint.cc> (raw)
In-Reply-To: <CAJ2a_DfCmbFmpTngFnXzYy07gvEzN5UhAhrE8Cd8PowevrLUNw@mail.gmail.com>
Christian G?ttsche <cgzones@googlemail.com> wrote:
> > Can you change this to:
> >
> > struct nft_secmark {
> > u32 secid;
> > char *ctx;
> > };
>
> Does the nla_policy struct needs an update too? (regarding then .len member)
>
> +static const struct nla_policy nft_secmark_policy[NFTA_SECMARK_MAX + 1] = {
> + [NFTA_SECMARK_CTX] = { .type = NLA_STRING, .len =
> NFT_SECMARK_CTX_MAXLEN },
> +}
>
> NFT_SECMARK_CTX_MAXLEN might be dropped then..
Better keep it, we can always increase this later it if needed.
Given the length matches what xtables uses it should be fine.
prev parent reply other threads:[~2018-09-23 15:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 9:16 [PATCH v2 1/2] netfilter: nf_tables: add SECMARK support Christian Göttsche
2018-09-23 9:16 ` [PATCH 2/2] netfilter: nf_tables: add requirements for connsecmark support Christian Göttsche
2018-09-23 13:51 ` Florian Westphal
2018-09-23 17:13 ` kbuild test robot
2018-09-24 3:03 ` kbuild test robot
2018-09-23 13:55 ` [PATCH v2 1/2] netfilter: nf_tables: add SECMARK support Florian Westphal
2018-09-23 15:31 ` Christian Göttsche
2018-09-23 15:41 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180923154129.ht55keytmgxcnl73@breakpoint.cc \
--to=fw@strlen.de \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).