From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=j9HE=NR=vger.kernel.org=linux-security-module-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id E026DC46464
	for <linux-security-module@archiver.kernel.org>; Tue,  6 Nov 2018 05:53:00 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id A743A2081D
	for <linux-security-module@archiver.kernel.org>; Tue,  6 Nov 2018 05:53:00 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A743A2081D
Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-security-module-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729480AbeKFPQa (ORCPT
        <rfc822;linux-security-module@archiver.kernel.org>);
        Tue, 6 Nov 2018 10:16:30 -0500
Received: from mga05.intel.com ([192.55.52.43]:12894 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1729342AbeKFPQa (ORCPT
        <rfc822;linux-security-module@vger.kernel.org>);
        Tue, 6 Nov 2018 10:16:30 -0500
X-Amp-Result: UNKNOWN
X-Amp-Original-Verdict: FILE UNKNOWN
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
  by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2018 21:52:59 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.54,470,1534834800"; 
   d="scan'208";a="97944827"
Received: from unknown (HELO localhost) ([10.249.254.149])
  by orsmga003.jf.intel.com with ESMTP; 05 Nov 2018 21:52:51 -0800
Date:   Tue, 6 Nov 2018 07:52:50 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To:     Stefan Berger <stefanb@linux.ibm.com>
Cc:     linux-integrity@vger.kernel.org,
        linux-security-module@vger.kernel.org,
        James Bottomley <James.Bottomley@HansenPartnership.com>,
        Tomas Winkler <tomas.winkler@intel.com>,
        Tadeusz Struk <tadeusz.struk@intel.com>,
        Stefan Berger <stefanb@linux.vnet.ibm.com>,
        Nayna Jain <nayna@linux.ibm.com>,
        Peter Huewe <peterhuewe@gmx.de>,
        Jason Gunthorpe <jgg@ziepe.ca>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 01/16] tpm: use tpm_buf in tpm_transmit_cmd() as the
 IO parameter
Message-ID: <20181106055250.GB15575@linux.intel.com>
References: <20181105014552.20262-1-jarkko.sakkinen@linux.intel.com>
 <20181105014552.20262-2-jarkko.sakkinen@linux.intel.com>
 <3b462772-c9a6-648c-fb05-b45bbff98a84@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3b462772-c9a6-648c-fb05-b45bbff98a84@linux.ibm.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: owner-linux-security-module@vger.kernel.org
Precedence: bulk
List-ID: <linux-security-module.vger.kernel.org>

On Mon, Nov 05, 2018 at 04:48:13PM -0500, Stefan Berger wrote:
> >   int tpm_send(struct tpm_chip *chip, void *cmd, size_t buflen)
> >   {
> > +	struct tpm_buf buf;
> >   	int rc;
> > 
> >   	chip = tpm_find_get_ops(chip);
> >   	if (!chip)
> >   		return -ENODEV;
> > 
> > -	rc = tpm_transmit_cmd(chip, NULL, cmd, buflen, 0, 0,
> > +	rc = tpm_buf_init(&buf, 0, 0);
> > +	if (rc)
> > +		goto out;
> > +
> > +	memcpy(buf.data, cmd, buflen);
> 
> 
> Nit: buflen -> cmd_len

Agreed that it should but I try to keep the patch as minimal and
mechanical as I can.

Thank you.

/Jarkko