* [PATCH] apparmor: Adjust offset when accessing task blob.
@ 2019-01-21 1:25 Tetsuo Handa
2019-01-22 17:41 ` Kees Cook
2019-01-22 22:41 ` James Morris
0 siblings, 2 replies; 3+ messages in thread
From: Tetsuo Handa @ 2019-01-21 1:25 UTC (permalink / raw)
To: linux-security-module
AppArmor will no longer be the only user of task blob
after TOMOYO started using task blob.
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
---
security/apparmor/include/task.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/apparmor/include/task.h b/security/apparmor/include/task.h
index 039c1e6..311e652 100644
--- a/security/apparmor/include/task.h
+++ b/security/apparmor/include/task.h
@@ -16,7 +16,7 @@
static inline struct aa_task_ctx *task_ctx(struct task_struct *task)
{
- return task->security;
+ return task->security + apparmor_blob_sizes.lbs_task;
}
/*
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] apparmor: Adjust offset when accessing task blob.
2019-01-21 1:25 [PATCH] apparmor: Adjust offset when accessing task blob Tetsuo Handa
@ 2019-01-22 17:41 ` Kees Cook
2019-01-22 22:41 ` James Morris
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2019-01-22 17:41 UTC (permalink / raw)
To: Tetsuo Handa; +Cc: linux-security-module
On Mon, Jan 21, 2019 at 10:25:10AM +0900, Tetsuo Handa wrote:
> AppArmor will no longer be the only user of task blob
> after TOMOYO started using task blob.
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
I just noticed this today too! You beat me to sending the patch. ;)
Fixes: f4ad8f2c4076 ("LSM: Infrastructure management of the task security")
Acked-by: Kees Cook <keescook@chromium.org>
James, this should get into v5.0 fixes tree.
-Kees
> ---
> security/apparmor/include/task.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/apparmor/include/task.h b/security/apparmor/include/task.h
> index 039c1e6..311e652 100644
> --- a/security/apparmor/include/task.h
> +++ b/security/apparmor/include/task.h
> @@ -16,7 +16,7 @@
>
> static inline struct aa_task_ctx *task_ctx(struct task_struct *task)
> {
> - return task->security;
> + return task->security + apparmor_blob_sizes.lbs_task;
> }
>
> /*
> --
> 1.8.3.1
--
Kees Cook @outflux.net
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] apparmor: Adjust offset when accessing task blob.
2019-01-21 1:25 [PATCH] apparmor: Adjust offset when accessing task blob Tetsuo Handa
2019-01-22 17:41 ` Kees Cook
@ 2019-01-22 22:41 ` James Morris
1 sibling, 0 replies; 3+ messages in thread
From: James Morris @ 2019-01-22 22:41 UTC (permalink / raw)
To: Tetsuo Handa; +Cc: linux-security-module
On Mon, 21 Jan 2019, Tetsuo Handa wrote:
> AppArmor will no longer be the only user of task blob
> after TOMOYO started using task blob.
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> ---
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-general
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-22 22:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-21 1:25 [PATCH] apparmor: Adjust offset when accessing task blob Tetsuo Handa
2019-01-22 17:41 ` Kees Cook
2019-01-22 22:41 ` James Morris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).