From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 504AFC282DA for ; Thu, 31 Jan 2019 16:08:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C578218AC for ; Thu, 31 Jan 2019 16:08:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388072AbfAaQIn (ORCPT ); Thu, 31 Jan 2019 11:08:43 -0500 Received: from mga12.intel.com ([192.55.52.136]:62561 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727189AbfAaQIn (ORCPT ); Thu, 31 Jan 2019 11:08:43 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2019 08:08:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,545,1539673200"; d="scan'208";a="112663701" Received: from rkazants-mobl.ccr.corp.intel.com (HELO localhost) ([10.249.254.212]) by orsmga006.jf.intel.com with ESMTP; 31 Jan 2019 08:08:39 -0800 Date: Thu, 31 Jan 2019 18:08:38 +0200 From: Jarkko Sakkinen To: Jerry Snitselaar Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH 2/2] tpm: don't print error message in tpm_transmit_cmd when tpm still testing Message-ID: <20190131160838.GE5629@linux.intel.com> References: <20190130224333.20373-1-jsnitsel@redhat.com> <20190130224333.20373-2-jsnitsel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190130224333.20373-2-jsnitsel@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Wed, Jan 30, 2019 at 03:43:33PM -0700, Jerry Snitselaar wrote: > Currently tpm_transmit_cmd will print an error message if the tpm > returns something other than TPM2_RC_SUCCESS. This means that if the > tpm returns that it is testing an error message will be printed, and > this can cause confusion for the end user. So avoid printing the error > message if TPM2_RC_TESTING is the return code. > > Reviewed-by: Jarkko Sakkinen > Signed-off-by: Jerry Snitselaar Tags in wrong order but, but don't worry about it. I'll apply this patch and include to the next PR. Thanks. /Jarkko