From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
tomas.winkler@intel.com
Subject: Re: Getting weird TPM error after rebasing my tree to security/next-general
Date: Thu, 31 Jan 2019 20:47:40 +0200 [thread overview]
Message-ID: <20190131184739.GA29056@linux.intel.com> (raw)
In-Reply-To: <CAHk-=wh+TBaphuAbHyNMdGYz=JM6tcuAfAsF_Kgthdev7oj2uA@mail.gmail.com>
On Thu, Jan 31, 2019 at 09:43:42AM -0800, Linus Torvalds wrote:
> On Thu, Jan 31, 2019 at 9:06 AM Jarkko Sakkinen
> <jarkko.sakkinen@linux.intel.com> wrote:
> >
> > Found something that *does* fix the issue. If I replace memcpy_*io()
> > calls with regular memcpy(), the driver works and all my tests pass.
>
> That's not surprising, since that's what we used to do. And it's
> horribly wrong because "memcpy()" can do things that are horribly
> wrong on IO accesses. Like doing them twice, but alternatively also
> "copy one byte at a time" which generally works, but is horrendously
> slow for IO.
Yup, was just a sanity check.
> Can you check *which* memcpy_*io() triggers the issue? Maybe by
> "bisecting" them (first perhaps on a file-by-file basis, and then
> within a file).
Already did that. See my follow-up.
/Jarkko
next prev parent reply other threads:[~2019-01-31 18:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 14:25 Getting weird TPM error after rebasing my tree to security/next-general Jarkko Sakkinen
2019-01-18 22:09 ` James Bottomley
2019-01-20 16:04 ` Jarkko Sakkinen
2019-01-22 1:02 ` Jarkko Sakkinen
2019-01-22 2:58 ` Jason Gunthorpe
2019-01-22 13:29 ` Jarkko Sakkinen
2019-01-22 18:26 ` Linus Torvalds
2019-01-23 15:36 ` Jarkko Sakkinen
2019-01-23 18:43 ` Linus Torvalds
2019-01-29 13:20 ` Jarkko Sakkinen
2019-01-31 12:26 ` Jarkko Sakkinen
2019-01-31 16:04 ` Jarkko Sakkinen
2019-01-31 17:06 ` Jarkko Sakkinen
2019-01-31 17:43 ` Linus Torvalds
2019-01-31 18:47 ` Jarkko Sakkinen [this message]
2019-01-31 18:35 ` Jarkko Sakkinen
2019-01-31 18:51 ` Linus Torvalds
2019-01-31 18:52 ` Linus Torvalds
2019-01-31 19:10 ` Linus Torvalds
2019-01-31 19:47 ` Winkler, Tomas
2019-02-01 8:12 ` Jarkko Sakkinen
2019-01-31 20:07 ` Winkler, Tomas
2019-01-31 20:47 ` Jarkko Sakkinen
2019-01-31 21:58 ` Linus Torvalds
2019-01-31 23:31 ` Jerry Snitselaar
2019-02-01 11:40 ` Jarkko Sakkinen
2019-01-31 20:45 ` Jarkko Sakkinen
2019-02-01 18:04 ` Linus Torvalds
2019-02-04 11:58 ` Jarkko Sakkinen
2019-01-23 20:11 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190131184739.GA29056@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tomas.winkler@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).