From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B91FC43381 for ; Wed, 20 Feb 2019 06:32:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0FEF92146E for ; Wed, 20 Feb 2019 06:32:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728691AbfBTGcH (ORCPT ); Wed, 20 Feb 2019 01:32:07 -0500 Received: from mga02.intel.com ([134.134.136.20]:61744 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbfBTGcH (ORCPT ); Wed, 20 Feb 2019 01:32:07 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Feb 2019 22:32:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,388,1544515200"; d="scan'208";a="140053323" Received: from ibanaga-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.254.248]) by orsmga001.jf.intel.com with ESMTP; 19 Feb 2019 22:32:02 -0800 Date: Wed, 20 Feb 2019 08:31:59 +0200 From: Jarkko Sakkinen To: YueHaibing Cc: peterhuewe@gmx.de, jgg@ziepe.ca, arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH v2 -next] tpm: Fix the type of the return value in calc_tpm2_event_size() Message-ID: <20190220063159.GA23027@linux.intel.com> References: <20190220022300.25888-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190220022300.25888-1-yuehaibing@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Wed, Feb 20, 2019 at 10:23:00AM +0800, YueHaibing wrote: > calc_tpm2_event_size() has an invalid signature because > it returns a 'size_t' where as its signature says that > it returns 'int'. > > Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware event log") > Suggested-by: Jarkko Sakkinen > Signed-off-by: YueHaibing Two remarks: - git config user.name "Yue Haibing" - "Cc: stable@vger.kernel.org" before the fixes tag. Thanks. /Jarkko