From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Matthew Garrett <matthewgarrett@google.com>
Cc: linux-integrity@vger.kernel.org, peterhuewe@gmx.de, jgg@ziepe.ca,
roberto.sassu@huawei.com, linux-efi@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, tweek@google.com,
Matthew Garrett <mjg59@google.com>
Subject: Re: [PATCH V4 2/4] tpm: Reserve the TPM final events table
Date: Wed, 27 Feb 2019 16:02:59 +0200 [thread overview]
Message-ID: <20190227140259.GA17106@linux.intel.com> (raw)
In-Reply-To: <20190222202606.160816-3-matthewgarrett@google.com>
On Fri, Feb 22, 2019 at 12:26:04PM -0800, Matthew Garrett wrote:
> From: Matthew Garrett <mjg59@google.com>
>
> UEFI systems provide a boot services protocol for obtaining the TPM
> event log, but this is unusable after ExitBootServices() is called.
> Unfortunately ExitBootServices() itself triggers additional TPM events
> that then can't be obtained using this protocol. The platform provides a
> mechanism for the OS to obtain these events by recording them to a
> separate UEFI configuration table which the OS can then map.
>
> Unfortunately this table isn't self describing in terms of providing its
> length, so we need to parse the events inside it to figure out how long
> it is. Since the table isn't mapped at this point, we need to extend the
> length calculation function to be able to map the event as it goes
> along.
>
> Signed-off-by: Matthew Garrett <mjg59@google.com>
Getting:
Applying: tpm: Reserve the TPM final events table
error: sha1 information is lacking or useless (drivers/firmware/efi/efi.c).
error: could not build fake ancestor
My tree:
git://git.infradead.org/users/jjs/linux-tpmdd.git
My guess is that your patches are based a later 5.0-rcX. Unfortunately I
cannot update my master at this point because my 5.1 PR was taken to
security tree and rebasing would change the commit IDs of 5.1 content
because security/next-general does not yet contain those patches.
/Jarkko
next prev parent reply other threads:[~2019-02-27 14:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 20:26 [PATCH V4 0/4] Add support for TCG2 event logs on EFI systems Matthew Garrett
2019-02-22 20:26 ` [PATCH V4 1/4] tpm: Abstract crypto agile event size calculations Matthew Garrett
2019-02-22 20:26 ` [PATCH V4 2/4] tpm: Reserve the TPM final events table Matthew Garrett
2019-02-27 14:02 ` Jarkko Sakkinen [this message]
2019-02-27 19:57 ` Matthew Garrett
2019-02-28 12:38 ` Jarkko Sakkinen
2019-02-22 20:26 ` [PATCH V4 3/4] tpm: Append the final event log to the TPM event log Matthew Garrett
2019-02-22 20:26 ` [PATCH V4 4/4] efi: Attempt to get the TCG2 event log in the boot stub Matthew Garrett
2019-02-26 14:03 ` [PATCH V4 0/4] Add support for TCG2 event logs on EFI systems Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190227140259.GA17106@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-efi@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=mjg59@google.com \
--cc=peterhuewe@gmx.de \
--cc=roberto.sassu@huawei.com \
--cc=tweek@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).