From: Tejun Heo <tj@kernel.org>
To: Jann Horn <jannh@google.com>
Cc: James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, Aristeu Rozanski <aris@redhat.com>,
"Serge E . Hallyn" <serge.hallyn@ubuntu.com>,
Michal Hocko <mhocko@suse.cz>,
cgroups@vger.kernel.org
Subject: Re: [PATCH] device_cgroup: fix RCU imbalance in error case
Date: Tue, 19 Mar 2019 10:47:25 -0700 [thread overview]
Message-ID: <20190319174725.GA69236@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <20190319013659.86199-1-jannh@google.com>
On Tue, Mar 19, 2019 at 02:36:59AM +0100, Jann Horn wrote:
> When dev_exception_add() returns an error (due to a failed memory
> allocation), make sure that we move the RCU preemption count back to where
> it was before we were called. We dropped the RCU read lock inside the loop
> body, so we can't just "break".
>
> sparse complains about this, too:
>
> $ make -s C=2 security/device_cgroup.o
> ./include/linux/rcupdate.h:647:9: warning: context imbalance in
> 'propagate_exception' - unexpected unlock
>
> Fixes: d591fb56618f ("device_cgroup: simplify cgroup tree walk in propagate_exception()")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jann Horn <jannh@google.com>
Applied to cgroup/for-5.1-fixes.
Thanks.
--
tejun
prev parent reply other threads:[~2019-03-19 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 1:36 [PATCH] device_cgroup: fix RCU imbalance in error case Jann Horn
2019-03-19 8:33 ` Michal Hocko
2019-03-19 17:47 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319174725.GA69236@devbig004.ftw2.facebook.com \
--to=tj@kernel.org \
--cc=aris@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=jannh@google.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mhocko@suse.cz \
--cc=serge.hallyn@ubuntu.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).