From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72B6CC282DA for ; Tue, 9 Apr 2019 19:19:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 380252084B for ; Tue, 9 Apr 2019 19:19:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=yahoo.com header.i=@yahoo.com header.b="G9S56UDD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726711AbfDITTG (ORCPT ); Tue, 9 Apr 2019 15:19:06 -0400 Received: from sonic302-28.consmr.mail.gq1.yahoo.com ([98.137.68.154]:34652 "EHLO sonic302-28.consmr.mail.gq1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726714AbfDITTE (ORCPT ); Tue, 9 Apr 2019 15:19:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1554837543; bh=bnhiZa2kx1PJdglKUm2qCM3rIeOnoh8kwEckh5gvzqc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From:Subject; b=G9S56UDDjDCObtjhss2HGd534Oox9M+orfd4XjNJNXIXibnXkA3P2bc4E61yE7LlvhGRTCR222FWEofr2M8l1CFseqsWKTKLQzf0yWL4tuHuEvts0GJ+tMBZQV3ixYSrNmB6LlpuiPlqSqsywweKaShLWhl74KXvw2NZcwA8pGRV5mzDha2lH73Bin9nM0AbDwfbQSz/rxqbtUQBEnWGoC/cuvwvm1evEzd8udICMeJoZMW3L4AKCFcvmkuCHuepM9E8a03tJwjiDPUcPVyzQPrWg1yBOOqqeWbl/KzaRsXZ9AeWPudTTv3YpcmXbdTvGpNEYKciV2qYUgvrbynfPw== X-YMail-OSG: qNZAkmwVM1lnFHEecY5df946UclB2wNbEjCodaapcsRBWqKA.3COozRUkl7KEqi i5gOUo78XJi5cp6t3T2dtDfw5oAR3.JYDBSTLfFDLwgMc0AQ6mPuH.ea2r3K4e0pXRfmf1.rph8F bdv4m7zaT_02l.mJ96.FJhnzSNCuqSL58EF9hztlTBblISVCpfNgmq2NO8LwfeWtizo_hFKjBk3H X3c4Atv1dLXZKQOIyUZqH3sEa32rD8asfff86dGc1uUsabZ1u9J4Hk7kUkKyPHoanumJ7rwDAk16 b_aUfamNC0Bi6hYyVHJzZd1awu2OJYJy4kRbZq63FuQjYt_w6H5v7lRzYJM_Jy5HnxydqSHTLVML rfrvSx5LYTCvJ6Km_4d4_YWj0DI4OMbrBQ9zjxJIIqScPHl3sUvExv_Mx6yKpJwlOWu9cLwcJSI9 LzIxAEJWof9JBFJunmeusV9bG_joWbB8iSAUh_ls6yrpgVjWx3x4p2sTOakom5nAcetEErA2aeVv dO9EwSHRS2wMxo4mgrJA3iZpxYODwYkVVXczD.rSyG3MvOQgIVQKnwF.ppkjEJQqJI_snBcg8Uos RJ6tbQZcWBxRz4u4mtpYVLDOOzhhynqduoXdbjuBb4.jMOJj4wQQuZlUbhLGzgtRY42F76Vd3KFc t5c0yZ7RsLd5eW6Z2wTozgf_bX7JwDdBJj9XLFxXcRkKgw8I4C0oRFdQDpHULP3cNihZBtm0BUWp JNynywyY9t4DjtuX.Irk5K9ePsQQrB5X1onV5.9BDbnFEWSqdAmBSEAqM3KOd4A2TrBB89OcXyWM 91wvNV0dTlej15HQob30sO3FKYw1RvQkc6ytMFFbD6qi0PbD97dTNDn_GYKVTJVS8V5suu3_szFC Z8k2aMTPCua4.dsR_4rpFKRsClfNmQN0p9iGqE9Z6j41PVUJ.a.wHVya031fDLh9WyI.acdnlKwE SukoVm_cd1jbmFTIWkIDGi5upVaywdjbV7GM78s.P8mVnZeBX6yW3ARkFztKz.kXUhTPZ3kBc52G p1sbNwgPM0SBFbl9TQaHP4gi35WH7joK6SqRSHKbDTPUfjoO3430rLWzLmzhPSwEjScY.mWIS9zW MIS4qGIm5UNnrnbhtYkYpDpCN2J_26IdMRD33YTP.0ZUr3pcde1949kQ- Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.gq1.yahoo.com with HTTP; Tue, 9 Apr 2019 19:19:03 +0000 Received: from c-67-169-65-224.hsd1.ca.comcast.net (EHLO localhost.localdomain) ([67.169.65.224]) by smtp417.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID b77b874e22efcf04356cc7acbadd009c; Tue, 09 Apr 2019 19:18:58 +0000 (UTC) From: Casey Schaufler To: jmorris@namei.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, casey.schaufler@intel.com Cc: keescook@chromium.org, john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp, paul@paul-moore.com, sds@tycho.nsa.gov Subject: [PATCH 08/59] LSM: Use lsm_export in the kernel_ask_as hooks Date: Tue, 9 Apr 2019 12:17:57 -0700 Message-Id: <20190409191848.1380-9-casey@schaufler-ca.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20190409191848.1380-1-casey@schaufler-ca.com> References: <20190409191848.1380-1-casey@schaufler-ca.com> Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: Convert the kernel_ask_as hooks to use the lsm_export structure instead of a u32 secid. There is some scaffolding involved that will be removed when security_kernel_ask_as() is updated. Signed-off-by: Casey Schaufler --- include/linux/lsm_hooks.h | 4 ++-- security/security.c | 15 ++++++++++++++- security/selinux/hooks.c | 17 ++++++++++++++--- security/smack/smack_lsm.c | 12 +++++++++++- 4 files changed, 41 insertions(+), 7 deletions(-) diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h index 544671f44dfa..85b8217ce2f2 100644 --- a/include/linux/lsm_hooks.h +++ b/include/linux/lsm_hooks.h @@ -578,7 +578,7 @@ * @kernel_act_as: * Set the credentials for a kernel service to act as (subjective context). * @new points to the credentials to be modified. - * @secid specifies the security ID to be set + * @l specifies the security data to be set * The current task must be the one that nominated @secid. * Return 0 if successful. * @kernel_create_files_as: @@ -1606,7 +1606,7 @@ union security_list_options { gfp_t gfp); void (*cred_transfer)(struct cred *new, const struct cred *old); void (*cred_getsecid)(const struct cred *c, struct lsm_export *l); - int (*kernel_act_as)(struct cred *new, u32 secid); + int (*kernel_act_as)(struct cred *new, struct lsm_export *l); int (*kernel_create_files_as)(struct cred *new, struct inode *inode); int (*kernel_module_request)(char *kmod_name); int (*kernel_load_data)(enum kernel_load_data_id id); diff --git a/security/security.c b/security/security.c index 802557ff6f60..3a766755b722 100644 --- a/security/security.c +++ b/security/security.c @@ -742,6 +742,15 @@ static inline void lsm_export_secid(struct lsm_export *data, u32 *secid) } } +static inline void lsm_export_to_all(struct lsm_export *data, u32 secid) +{ + data->selinux = secid; + data->smack = secid; + data->apparmor = secid; + data->flags = LSM_EXPORT_SELINUX | LSM_EXPORT_SMACK | + LSM_EXPORT_APPARMOR; +} + /* Security operations */ int security_binder_set_context_mgr(struct task_struct *mgr) @@ -1647,7 +1656,11 @@ EXPORT_SYMBOL(security_cred_getsecid); int security_kernel_act_as(struct cred *new, u32 secid) { - return call_int_hook(kernel_act_as, 0, new, secid); + struct lsm_export data = { .flags = LSM_EXPORT_NONE }; + + lsm_export_to_all(&data, secid); + + return call_int_hook(kernel_act_as, 0, new, &data); } int security_kernel_create_files_as(struct cred *new, struct inode *inode) diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index c82108793fb5..8d4334f68a65 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -222,6 +222,14 @@ static inline void selinux_export_secid(struct lsm_export *l, u32 secid) l->flags |= LSM_EXPORT_SELINUX; } +static inline void selinux_import_secid(struct lsm_export *l, u32 *secid) +{ + if (l->flags | LSM_EXPORT_SELINUX) + *secid = l->selinux; + else + *secid = SECSID_NULL; +} + /* * get the security ID of a set of credentials */ @@ -3773,19 +3781,22 @@ static void selinux_cred_getsecid(const struct cred *c, struct lsm_export *l) * set the security data for a kernel service * - all the creation contexts are set to unlabelled */ -static int selinux_kernel_act_as(struct cred *new, u32 secid) +static int selinux_kernel_act_as(struct cred *new, struct lsm_export *l) { struct task_security_struct *tsec = selinux_cred(new); + u32 nsid; u32 sid = current_sid(); int ret; + selinux_import_secid(l, &nsid); + ret = avc_has_perm(&selinux_state, - sid, secid, + sid, nsid, SECCLASS_KERNEL_SERVICE, KERNEL_SERVICE__USE_AS_OVERRIDE, NULL); if (ret == 0) { - tsec->sid = secid; + tsec->sid = nsid; tsec->create_sid = 0; tsec->keycreate_sid = 0; tsec->sockcreate_sid = 0; diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c index 13ac3045a388..da85d607d40a 100644 --- a/security/smack/smack_lsm.c +++ b/security/smack/smack_lsm.c @@ -475,6 +475,14 @@ static inline void smack_export_secid(struct lsm_export *l, u32 secid) l->flags |= LSM_EXPORT_SMACK; } +static inline void smack_import_secid(struct lsm_export *l, u32 *secid) +{ + if (l->flags | LSM_EXPORT_SMACK) + *secid = l->smack; + else + *secid = 0; +} + /* * LSM hooks. * We he, that is fun! @@ -1997,10 +2005,12 @@ static void smack_cred_getsecid(const struct cred *cred, struct lsm_export *l) * * Set the security data for a kernel service. */ -static int smack_kernel_act_as(struct cred *new, u32 secid) +static int smack_kernel_act_as(struct cred *new, struct lsm_export *l) { + u32 secid; struct task_smack *new_tsp = smack_cred(new); + smack_import_secid(l, &secid); new_tsp->smk_task = smack_from_secid(secid); return 0; } -- 2.19.1