From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A10C0651F for ; Thu, 4 Jul 2019 19:59:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F99721852 for ; Thu, 4 Jul 2019 19:59:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727032AbfGDT7Q (ORCPT ); Thu, 4 Jul 2019 15:59:16 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:50461 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbfGDT7P (ORCPT ); Thu, 4 Jul 2019 15:59:15 -0400 Received: from 162-237-133-238.lightspeed.rcsntx.sbcglobal.net ([162.237.133.238] helo=elm) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hj7sn-00065o-5y; Thu, 04 Jul 2019 19:59:05 +0000 Date: Thu, 4 Jul 2019 14:58:58 -0500 From: Tyler Hicks To: Mimi Zohar Cc: Roberto Sassu , Jarkko Sakkinen , Michal Suchanek , linux-integrity@vger.kernel.org, Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , James Bottomley , David Howells , Tomas Winkler , Armijn Hemel , Stefan Berger , Jerry Snitselaar , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH] Revert "tpm: pass an array of tpm_extend_digest structures to tpm_pcr_extend()" Message-ID: <20190704195857.GB6105@elm> References: <20190701131505.17759-1-msuchanek@suse.de> <8e4cc105b748c5395132b4d3d29d0d9b30a8720c.camel@linux.intel.com> <1562240882.6165.78.camel@linux.ibm.com> <1562255201.6165.143.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1562255201.6165.143.camel@linux.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: Hey Mimi! On 2019-07-04 11:46:41, Mimi Zohar wrote: > Hi Jarkko, > > On Thu, 2019-07-04 at 07:48 -0400, Mimi Zohar wrote: > > On Thu, 2019-07-04 at 13:28 +0200, Roberto Sassu wrote: > > > On 7/4/2019 12:03 PM, Jarkko Sakkinen wrote: > > > > On Mon, 2019-07-01 at 15:15 +0200, Michal Suchanek wrote: > > > >> This reverts commit 0b6cf6b97b7ef1fa3c7fefab0cac897a1c4a3400 to avoid > > > >> following crash: > > > > > > > > Thank you. I think this the right choice for the moment. I fixed > > > > a trivial checkpatch.pl error and added the mandatory tags. Can > > > > you check quickly v2 (just posted)? > > > > > > > > I already made it available in my master and next. > > > > > > Could you please wait few days? I would prefer to fix this issue instead > > > of reverting the whole patch. > > > > Nayna posted a patch late yesterday titled "tpm: fixes uninitialized > > allocated banks for IBM vtpm driver", which addresses this bug. > > Now with my review, and with Sachin Sant's and Michal Suchánek > testing, instead of reverting this patch could you pick up Nayna's > patch instead? It looks to me like the revert would also fix a bug that is keeping the eCryptfs module from loading when the TPM is in an "inactive" state: https://bugzilla.kernel.org/show_bug.cgi?id=203953 I just noticed that it was recently discussed here, too: https://lore.kernel.org/linux-integrity/1562244125.6165.95.camel@linux.ibm.com/T/#t I believe that the revert would fix it because the call to init_digests()/tpm_get_random() would no longer be in the path of loading ecryptfs.ko (which depends on encrypted-keys.ko, which depends on trusted.ko). If the revert isn't used, we'll need a different fix for bug 203953. It should be an easy fix but I don't want it to be forgotten. Tyler > > thanks! > > Mimi >