From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96ACCC3A59E for ; Wed, 21 Aug 2019 19:14:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E64C22DD3 for ; Wed, 21 Aug 2019 19:14:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729730AbfHUTOD (ORCPT ); Wed, 21 Aug 2019 15:14:03 -0400 Received: from mga11.intel.com ([192.55.52.93]:18917 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727038AbfHUTOD (ORCPT ); Wed, 21 Aug 2019 15:14:03 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Aug 2019 12:14:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,412,1559545200"; d="scan'208";a="178596414" Received: from kumarsh1-mobl.ger.corp.intel.com (HELO localhost) ([10.249.33.104]) by fmsmga008.fm.intel.com with ESMTP; 21 Aug 2019 12:13:55 -0700 Date: Wed, 21 Aug 2019 22:13:54 +0300 From: Jarkko Sakkinen To: Sumit Garg Cc: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , linux-security-module@vger.kernel.org, dhowells@redhat.com, Herbert Xu , davem@davemloft.net, peterhuewe@gmx.de, jgg@ziepe.ca, jejb@linux.ibm.com, Arnd Bergmann , Greg Kroah-Hartman , Mimi Zohar , James Morris , "Serge E. Hallyn" , Casey Schaufler , Ard Biesheuvel , Daniel Thompson , Linux Kernel Mailing List , "tee-dev @ lists . linaro . org" Subject: Re: [RFC/RFT v4 1/5] tpm: move tpm_buf code to include/linux/ Message-ID: <20190821191354.4redyuo5j2njkruy@linux.intel.com> References: <1565682784-10234-1-git-send-email-sumit.garg@linaro.org> <1565682784-10234-2-git-send-email-sumit.garg@linaro.org> <20190819165629.qv7cmg6kiwb6oxig@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20180716 Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Tue, Aug 20, 2019 at 11:22:05AM +0530, Sumit Garg wrote: > On Mon, 19 Aug 2019 at 22:26, Jarkko Sakkinen > wrote: > > > > On Tue, Aug 13, 2019 at 01:23:00PM +0530, Sumit Garg wrote: > > > Move tpm_buf code to common include/linux/tpm.h header so that it can > > > be reused via other subsystems like trusted keys etc. > > > > > > Also rename trusted keys TPM 1.x buffer implementation to tpm1_buf to > > > avoid any compilation errors. > > > > > > Suggested-by: Jarkko Sakkinen > > > Signed-off-by: Sumit Garg > > > > A question: did you try to do this as mechanically as you ever could > > or did you do any other code changes? I did go through it but it is > > possible that I missed something. > > > > There aren't any other code changes apart from "tpm1_buf" rename. Thanks. I had to ask because it would be hard to check it manually. /Jarkko