From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A69B9CA9EAF for ; Thu, 24 Oct 2019 18:40:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 81ED521906 for ; Thu, 24 Oct 2019 18:40:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440124AbfJXSkQ (ORCPT ); Thu, 24 Oct 2019 14:40:16 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:48390 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2440123AbfJXSkQ (ORCPT ); Thu, 24 Oct 2019 14:40:16 -0400 Received: from 162-237-133-238.lightspeed.rcsntx.sbcglobal.net ([162.237.133.238] helo=elm) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iNi1j-00084R-70; Thu, 24 Oct 2019 18:40:03 +0000 Date: Thu, 24 Oct 2019 13:39:59 -0500 From: Tyler Hicks To: Navid Emamdoost Cc: Julia Lawall , John Johansen , Navid Emamdoost , Stephen McCamant , Kangjie Lu , James Morris , "Serge E. Hallyn" , linux-security-module@vger.kernel.org, LKML Subject: Re: [PATCH] apparmor: fix odd_ptr_err.cocci warnings (fwd) Message-ID: <20191024183958.GA29190@elm> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On 2019-10-24 13:35:24, Navid Emamdoost wrote: > Hello, > > I added Tyler to this conversation. > I believe v3 of the patch addresses this issue: > https://lore.kernel.org/patchwork/patch/1142523/ Yes, I agree. v3 is the fix. Tyler > > > On Thu, Oct 24, 2019 at 6:28 AM Julia Lawall wrote: > > > > Hello, > > > > The change suggested by Coccinelle is not correct, but the original code > > is not correct either because the argument to PTR_ERR should be a pointer, > > not an integer. > > > > julia > > > > ---------- Forwarded message ---------- > > Date: Thu, 24 Oct 2019 18:21:57 +0800 > > From: kbuild test robot > > To: kbuild@lists.01.org > > Cc: Julia Lawall > > Subject: [PATCH] apparmor: fix odd_ptr_err.cocci warnings > > > > CC: kbuild-all@lists.01.org > > In-Reply-To: <20191021152348.3906-1-navid.emamdoost@gmail.com> > > References: <20191021152348.3906-1-navid.emamdoost@gmail.com> > > TO: Navid Emamdoost > > > > From: kbuild test robot > > > > security/apparmor/audit.c:199:5-11: inconsistent IS_ERR and PTR_ERR on line 202. > > > > PTR_ERR should access the value just tested by IS_ERR > > > > Semantic patch information: > > There can be false positives in the patch case, where it is the call to > > IS_ERR that is wrong. > > > > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > > > > Fixes: 6f939f24599c ("apparmor: Fix use-after-free in aa_audit_rule_init") > > CC: Navid Emamdoost > > Signed-off-by: kbuild test robot > > --- > > > > url: https://github.com/0day-ci/linux/commits/Navid-Emamdoost/apparmor-Fix-use-after-free-in-aa_audit_rule_init/20191024-123239 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-testing > > :::::: branch date: 6 hours ago > > :::::: commit date: 6 hours ago > > > > Please take the patch only if it's a positive warning. Thanks! > > > > audit.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- a/security/apparmor/audit.c > > +++ b/security/apparmor/audit.c > > @@ -199,7 +199,7 @@ int aa_audit_rule_init(u32 field, u32 op > > if (IS_ERR(rule->label)) { > > int err = rule->label; > > aa_audit_rule_free(rule); > > - return PTR_ERR(err); > > + return PTR_ERR(rule->label); > > } > > > > *vrule = rule; > > > > -- > Navid.