From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: zhengbin <zhengbin13@huawei.com>
Cc: dhowells@redhat.com, jmorris@namei.org, serge@hallyn.com,
sumit.garg@linaro.org, keyrings@vger.kernel.org,
linux-security-module@vger.kernel.org, yi.zhang@huawei.com
Subject: Re: [PATCH] KEYS: trusted: Remove set but not used variable 'keyhndl'
Date: Tue, 29 Oct 2019 16:18:52 +0200 [thread overview]
Message-ID: <20191029141852.GB7415@linux.intel.com> (raw)
In-Reply-To: <20191029141637.GA7415@linux.intel.com>
On Tue, Oct 29, 2019 at 04:16:37PM +0200, Jarkko Sakkinen wrote:
> On Tue, Oct 29, 2019 at 05:33:32PM +0800, zhengbin wrote:
> > Fixes gcc '-Wunused-but-set-variable' warning:
> >
> > security/keys/trusted-keys/trusted_tpm1.c: In function tpm_unseal:
> > security/keys/trusted-keys/trusted_tpm1.c:588:11: warning: variable keyhndl set but not used [-Wunused-but-set-variable]
> >
> > It is introduced by commit 00aa975bd031 ("KEYS: trusted:
> > Create trusted keys subsystem"), but never used, so remove it.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: zhengbin <zhengbin13@huawei.com>
>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> I'll pick this to my tree.
Please use fixes tag next time instead of ad hoc.
Anyway, applied, thanks.
/Jarkko
prev parent reply other threads:[~2019-10-29 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 9:33 [PATCH] KEYS: trusted: Remove set but not used variable 'keyhndl' zhengbin
2019-10-29 14:16 ` Jarkko Sakkinen
2019-10-29 14:18 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029141852.GB7415@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=sumit.garg@linaro.org \
--cc=yi.zhang@huawei.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).