linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serge@hallyn.com>
To: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Matthew Garrett <matthewgarrett@google.com>,
	James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] security: remove EARLY_LSM_COUNT which never used
Date: Thu, 23 Jan 2020 11:38:18 -0600	[thread overview]
Message-ID: <20200123173818.GA26551@mail.hallyn.com> (raw)
In-Reply-To: <1579596603-258380-1-git-send-email-alex.shi@linux.alibaba.com>

On Tue, Jan 21, 2020 at 04:50:03PM +0800, Alex Shi wrote:
> This macro is never used from it was introduced in commit e6b1db98cf4d5
> ("security: Support early LSMs"), better to remove it.
> 
> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: Matthew Garrett <matthewgarrett@google.com>
> Cc: James Morris <jmorris@namei.org> 
> Cc: "Serge E. Hallyn" <serge@hallyn.com> 

Acked-by: Serge Hallyn <serge@hallyn.com>

Does indeed seem unused.

> Cc: linux-security-module@vger.kernel.org 
> Cc: linux-kernel@vger.kernel.org 
> ---
>  security/security.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/security/security.c b/security/security.c
> index cd2d18d2d279..b9771de83cf7 100644
> --- a/security/security.c
> +++ b/security/security.c
> @@ -33,7 +33,6 @@
>  
>  /* How many LSMs were built into the kernel? */
>  #define LSM_COUNT (__end_lsm_info - __start_lsm_info)
> -#define EARLY_LSM_COUNT (__end_early_lsm_info - __start_early_lsm_info)
>  
>  struct security_hook_heads security_hook_heads __lsm_ro_after_init;
>  static BLOCKING_NOTIFIER_HEAD(blocking_lsm_notifier_chain);
> -- 
> 1.8.3.1

  reply	other threads:[~2020-01-23 17:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-21  8:50 [PATCH] security: remove EARLY_LSM_COUNT which never used Alex Shi
2020-01-23 17:38 ` Serge E. Hallyn [this message]
2020-01-23 23:44 ` James Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200123173818.GA26551@mail.hallyn.com \
    --to=serge@hallyn.com \
    --cc=alex.shi@linux.alibaba.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=matthewgarrett@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).