From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Waiman Long <longman@redhat.com>
Cc: David Howells <dhowells@redhat.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Mimi Zohar <zohar@linux.ibm.com>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-integrity@vger.kernel.org,
Sumit Garg <sumit.garg@linaro.org>,
Jerry Snitselaar <jsnitsel@redhat.com>,
Roberto Sassu <roberto.sassu@huawei.com>,
Eric Biggers <ebiggers@google.com>,
Chris von Recklinghausen <crecklin@redhat.com>
Subject: Re: [PATCH v3 2/3] KEYS: Avoid false positive ENOMEM error on key read
Date: Sun, 15 Mar 2020 23:32:45 +0200 [thread overview]
Message-ID: <20200315213245.GF224162@linux.intel.com> (raw)
In-Reply-To: <20200313152102.1707-3-longman@redhat.com>
On Fri, Mar 13, 2020 at 11:21:01AM -0400, Waiman Long wrote:
> - * Read methods will just return the required length
> - * without any copying if the provided length isn't big
> - * enough.
> + * We don't want an erronous -ENOMEM error due to an
> + * arbitrary large user-supplied buflen. So if buflen
> + * exceeds a threshold (1024 bytes in this case), we call
> + * the read method twice. The first time to get the buffer
> + * length and the second time to read out the key data.
> + *
> + * N.B. All the read methods will return the required
> + * buffer length with a NULL input buffer or when
> + * the input buffer length isn't large enough.
> */
> + if (buflen <= 0x400) {
1. The overwhelmingly long comment. Will be destined to rotten.
2. Magic number.
3. The cap must be updated both in comment and code, and not only
that, but the numbers use a different base (dec and hex).
/Jarkko
next prev parent reply other threads:[~2020-03-15 21:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 15:20 [PATCH v3 0/3] KEYS: Read keys to internal buffer & then copy to userspace Waiman Long
2020-03-13 15:21 ` [PATCH v3 1/3] KEYS: Don't write out to userspace while holding key semaphore Waiman Long
2020-03-15 19:21 ` Jarkko Sakkinen
2020-03-15 21:27 ` Jarkko Sakkinen
2020-03-16 11:22 ` David Howells
2020-03-16 13:53 ` Jarkko Sakkinen
2020-03-16 16:33 ` Waiman Long
2020-03-17 18:10 ` Waiman Long
2020-03-16 11:34 ` David Howells
2020-03-13 15:21 ` [PATCH v3 2/3] KEYS: Avoid false positive ENOMEM error on key read Waiman Long
2020-03-15 21:32 ` Jarkko Sakkinen [this message]
2020-03-17 18:36 ` Waiman Long
2020-03-13 15:21 ` [PATCH v3 3/3] KEYS: Use kvmalloc() to better handle large buffer allocation Waiman Long
2020-03-13 16:43 ` Eric Biggers
2020-03-13 17:49 ` Waiman Long
2020-03-15 21:52 ` Jarkko Sakkinen
2020-03-15 22:01 ` Waiman Long
2020-03-16 11:50 ` [PATCH v3 1/3] KEYS: Don't write out to userspace while holding key semaphore David Howells
2020-03-17 18:09 ` Waiman Long
2020-03-16 14:24 ` [PATCH v3 3/3] KEYS: Use kvmalloc() to better handle large buffer allocation David Howells
2020-03-16 15:21 ` Waiman Long
2020-03-16 22:19 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200315213245.GF224162@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=crecklin@redhat.com \
--cc=dhowells@redhat.com \
--cc=ebiggers@google.com \
--cc=jmorris@namei.org \
--cc=jsnitsel@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=longman@redhat.com \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=sumit.garg@linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).