From: Tejun Heo <tj@kernel.org>
To: Odin Ugedal <odin@ugedal.com>
Cc: bpf@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, Harish.Kasiviswanathan@amd.com,
guro@fb.com, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] device_cgroup: Cleanup cgroup eBPF device filter code
Date: Mon, 13 Apr 2020 14:43:00 -0400 [thread overview]
Message-ID: <20200413184300.GE60335@mtj.duckdns.org> (raw)
In-Reply-To: <20200403175528.225990-1-odin@ugedal.com>
On Fri, Apr 03, 2020 at 07:55:28PM +0200, Odin Ugedal wrote:
> Original cgroup v2 eBPF code for filtering device access made it
> possible to compile with CONFIG_CGROUP_DEVICE=n and still use the eBPF
> filtering. Change
> commit 4b7d4d453fc4 ("device_cgroup: Export devcgroup_check_permission")
> reverted this, making it required to set it to y.
>
> Since the device filtering (and all the docs) for cgroup v2 is no longer
> a "device controller" like it was in v1, someone might compile their
> kernel with CONFIG_CGROUP_DEVICE=n. Then (for linux 5.5+) the eBPF
> filter will not be invoked, and all processes will be allowed access
> to all devices, no matter what the eBPF filter says.
Applied to cgroup/for-5.7-fixes.
Thanks.
--
tejun
prev parent reply other threads:[~2020-04-13 18:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 17:55 [PATCH] device_cgroup: Cleanup cgroup eBPF device filter code Odin Ugedal
2020-04-03 18:05 ` Odin Ugedal
2020-04-03 22:37 ` Roman Gushchin
2020-04-06 20:30 ` Daniel Borkmann
2020-04-13 18:43 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200413184300.GE60335@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=Harish.Kasiviswanathan@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bpf@vger.kernel.org \
--cc=guro@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=odin@ugedal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).