From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Richard Hughes <hughsient@gmail.com>
Cc: Mario Limonciello <Mario.Limonciello@dell.com>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
linux-security-module <linux-security-module@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: Export LPC attributes for the system SPI chip
Date: Tue, 12 May 2020 09:44:01 +0300 [thread overview]
Message-ID: <20200512064401.GF487496@lahna.fi.intel.com> (raw)
In-Reply-To: <CAD2FfiHo1EzRupjgKhtLX0Zguq-bVeW5+u_PNQGAzV0x+AtfVw@mail.gmail.com>
On Mon, May 11, 2020 at 09:08:31PM +0100, Richard Hughes wrote:
> > For the security stuff you are adding, do you need to look at the PCI
> > device registers as well?
>
> No, just the config space. I guess at some point I might want to put
> some of the chipsec vulnerability checks into the module, although I'm
> not happy adding anything remotely dangerous.
I mean for the SPI-NOR controller PCI device registers (not the LPC PCI
device, sorry about not being clear), like config space. Typically it is
PCI device 1f.5 and in that case you can't use the LPC driver because it
should not touch other devices than what it is bound to (OK, there are
exceptions but still).
If that's the case then I guess this should go to intel-spi-pci/platform
drivers after all. I think one option is that we add Kconfig option that
makes the driver load but only provide the security bits without
actually calling intel_spi_probe().
next prev parent reply other threads:[~2020-05-12 6:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 15:52 [PATCH] platform/x86: Export LPC attributes for the system SPI chip Richard Hughes
2020-05-06 16:29 ` Andy Shevchenko
2020-05-06 16:39 ` Richard Hughes
2020-05-07 17:05 ` Javier Martinez Canillas
2020-05-07 17:22 ` Andy Shevchenko
2020-05-07 17:28 ` Javier Martinez Canillas
2020-05-07 17:45 ` Mario.Limonciello
2020-05-07 18:47 ` Richard Hughes
2020-05-07 19:22 ` Mario.Limonciello
2020-05-07 19:49 ` Richard Hughes
2020-05-07 20:03 ` Mario.Limonciello
2020-05-08 8:20 ` Mika Westerberg
2020-05-08 16:15 ` Richard Hughes
2020-05-11 10:45 ` Mika Westerberg
2020-05-11 15:40 ` Richard Hughes
2020-05-11 16:28 ` Mika Westerberg
2020-05-11 20:08 ` Richard Hughes
2020-05-12 6:44 ` Mika Westerberg [this message]
2020-05-12 20:37 ` Richard Hughes
2020-05-08 17:27 ` Mario.Limonciello
2020-05-11 10:41 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512064401.GF487496@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Mario.Limonciello@dell.com \
--cc=hughsient@gmail.com \
--cc=linux-security-module@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).