From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 127ECC433DF for ; Thu, 18 Jun 2020 01:46:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E04E520897 for ; Thu, 18 Jun 2020 01:46:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592444777; bh=3s0XwS/Il4BAewk92qDCbzVQej2QngsS9+LwdC2JKxk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jmbYXcyJ5B2JR2EolQXQ1mJ0cNG+EEytFHfvQEzqIh30N7Bt5zBaAHrNIZv3rG/qn FBSS77k0OPbHITlJNRac9rJXcFePXrSXGKEtlT2UiY8sitAnd6wR7mHKtzxSZh58rU Zasyq9pQopgEUzdvbmVxvSU1vRvpKFl7TvaZWiac= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728383AbgFRBqI (ORCPT ); Wed, 17 Jun 2020 21:46:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:37302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732107AbgFRB2c (ORCPT ); Wed, 17 Jun 2020 21:28:32 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A325F2220F; Thu, 18 Jun 2020 01:28:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592443712; bh=3s0XwS/Il4BAewk92qDCbzVQej2QngsS9+LwdC2JKxk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z4h4xfq93GrGQjAvQ1ZNSZBY8ulqU3AyMO4npPDeG4WqfPVMYzfg0ROShXU576Po5 Q4STJoaFR9gzDHQWgyTNUu0aEr1NOO4uxXC9cDkSGD4Rx1+3I/AAgFPOXv2IOYyAPz noJyzyFK3T3O1W1Nr9S9PVMF65Q9ZNiTT9duvEYY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Casey Schaufler , Hillf Danton , syzbot+bfdd4a2f07be52351350@syzkaller.appspotmail.com, Sasha Levin , linux-security-module@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 10/80] Smack: slab-out-of-bounds in vsscanf Date: Wed, 17 Jun 2020 21:27:09 -0400 Message-Id: <20200618012819.609778-10-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618012819.609778-1-sashal@kernel.org> References: <20200618012819.609778-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: From: Casey Schaufler [ Upstream commit 84e99e58e8d1e26f04c097f4266e431a33987f36 ] Add barrier to soob. Return -EOVERFLOW if the buffer is exceeded. Suggested-by: Hillf Danton Reported-by: syzbot+bfdd4a2f07be52351350@syzkaller.appspotmail.com Signed-off-by: Casey Schaufler Signed-off-by: Sasha Levin --- security/smack/smackfs.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c index 6492fe96cae4..3397b216bc6c 100644 --- a/security/smack/smackfs.c +++ b/security/smack/smackfs.c @@ -901,11 +901,21 @@ static ssize_t smk_set_cipso(struct file *file, const char __user *buf, else rule += strlen(skp->smk_known) + 1; + if (rule > data + count) { + rc = -EOVERFLOW; + goto out; + } + ret = sscanf(rule, "%d", &maplevel); if (ret != 1 || maplevel > SMACK_CIPSO_MAXLEVEL) goto out; rule += SMK_DIGITLEN; + if (rule > data + count) { + rc = -EOVERFLOW; + goto out; + } + ret = sscanf(rule, "%d", &catlen); if (ret != 1 || catlen > SMACK_CIPSO_MAXCATNUM) goto out; -- 2.25.1