From: KP Singh <kpsingh@chromium.org>
To: kernel test robot <lkp@intel.com>
Cc: KP Singh <kpsingh@chromium.org>,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
linux-security-module@vger.kernel.org, kbuild-all@lists.01.org,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Paul Turner <pjt@google.com>, Jann Horn <jannh@google.com>,
Florent Revest <revest@chromium.org>
Subject: Re: [PATCH bpf-next v3 2/4] bpf: Implement bpf_local_storage for inodes
Date: Thu, 9 Jul 2020 11:44:14 +0200 [thread overview]
Message-ID: <20200709094414.GB3743174@google.com> (raw)
In-Reply-To: <202007091250.vqzrSanp%lkp@intel.com>
On 09-Jul 12:37, kernel test robot wrote:
> Hi KP,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on bpf-next/master]
>
> url: https://github.com/0day-ci/linux/commits/KP-Singh/Generalizing-bpf_local_storage/20200709-085810
> base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
> config: mips-allyesconfig (attached as .config)
> compiler: mips-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> kernel/bpf/bpf_inode_storage.c:274:17: warning: no previous prototype for 'inode_storage_map_alloc' [-Wmissing-prototypes]
> 274 | struct bpf_map *inode_storage_map_alloc(union bpf_attr *attr)
> | ^~~~~~~~~~~~~~~~~~~~~~~
> >> kernel/bpf/bpf_inode_storage.c:286:6: warning: no previous prototype for 'inode_storage_map_free' [-Wmissing-prototypes]
> 286 | void inode_storage_map_free(struct bpf_map *map)
> | ^~~~~~~~~~~~~~~~~~~~~~
Thanks! Should have been static. Fixed these. Will send a v4 with
these fixes.
- KP
>
> vim +/inode_storage_map_alloc +274 kernel/bpf/bpf_inode_storage.c
>
> 273
> > 274 struct bpf_map *inode_storage_map_alloc(union bpf_attr *attr)
> 275 {
> 276 struct bpf_local_storage_map *smap;
> 277
> 278 smap = bpf_local_storage_map_alloc(attr);
> 279 if (IS_ERR(smap))
> 280 return ERR_CAST(smap);
> 281
> 282 smap->cache_idx = cache_idx_get_inode();
> 283 return &smap->map;
> 284 }
> 285
> > 286 void inode_storage_map_free(struct bpf_map *map)
> 287 {
> 288 struct bpf_local_storage_map *smap;
> 289
> 290 smap = (struct bpf_local_storage_map *)map;
> 291 cache_idx_free_inode(smap->cache_idx);
> 292 bpf_local_storage_map_free(smap);
> 293 }
> 294
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2020-07-09 9:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 0:56 [PATCH bpf-next v3 0/4] Generalizing bpf_local_storage KP Singh
2020-07-09 0:56 ` [PATCH bpf-next v3 1/4] bpf: Generalize bpf_sk_storage KP Singh
[not found] ` <202007091053.Se7i8FMj%lkp@intel.com>
2020-07-09 9:43 ` KP Singh
2020-07-09 0:56 ` [PATCH bpf-next v3 2/4] bpf: Implement bpf_local_storage for inodes KP Singh
2020-07-09 4:37 ` kernel test robot
2020-07-09 9:44 ` KP Singh [this message]
2020-07-09 0:56 ` [PATCH bpf-next v3 3/4] bpf: Allow local storage to be used from LSM programs KP Singh
2020-07-09 0:56 ` [PATCH bpf-next v3 4/4] bpf: Add selftests for local_storage KP Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709094414.GB3743174@google.com \
--to=kpsingh@chromium.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jannh@google.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pjt@google.com \
--cc=revest@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).