From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE45CC433E1 for ; Thu, 9 Jul 2020 09:44:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A899B20708 for ; Thu, 9 Jul 2020 09:44:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="RCWQxaOw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726339AbgGIJoS (ORCPT ); Thu, 9 Jul 2020 05:44:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726298AbgGIJoS (ORCPT ); Thu, 9 Jul 2020 05:44:18 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1095DC08C5DC for ; Thu, 9 Jul 2020 02:44:18 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id 22so1135146wmg.1 for ; Thu, 09 Jul 2020 02:44:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PLl8OGvUeLOUUHW/T0CxgP8wd4Pzfx4sJngI6R0Dk2g=; b=RCWQxaOwpdUwdEFhduGiA6uwtsGwtdmZmu/w2hP7tQ/eos6XNZ/YlES+c4PwzEKj+Y HQkos90UhTQasFzNe/cDxsHfeoGRKNVhLdznUCEVYfDUT7E3jRkULn72PsOU0lvjAntJ Ma6SaS+g2yKKTYX09rwBQQ2IPFgTl+ifezp4Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PLl8OGvUeLOUUHW/T0CxgP8wd4Pzfx4sJngI6R0Dk2g=; b=D4ZlRCR0zy4Dg+JkOm6rOWwGs9QLP244PTo5YLr06QJb89rc1S+kCCpiDyTkHiI5Lm +gdxSKyqhqMeYRApJyZGqQCJFwVOGBPGw9cvhOa7+PdCW5pXKxEi991uUTsmtBSlSAxT GG5fluGLOBc+JSsg4W5dd5/lNVdb4bYXtq/VWSK3FX8+B+pIRsN9F8PucleZygNo0Uxa vED/ElqMMN+7L39z4X2mR5ipntCCzf226zQy7iw5vZe4Y6F2wy2bsciYcIIE+yaFwJDG 2FysE9D2qZTVyOKoQspAc6wGQ5FILIuIT3mY/qqpTB0Qlnt1JQKxnM7ZiGiN2P6MHf/N +7fg== X-Gm-Message-State: AOAM530uRm47+/N3WFzXsFQl1qqGPA1pQKCMklaEoYzuF43ayHhHSmYk BnzJ27ZT2UOX2KVhC5RIV+QH1g== X-Google-Smtp-Source: ABdhPJyRm2EixjAzjNZ646eajs00dz37zv870XnIyWv48JP6xCPL/xdYrDA1J4Cc5c8ZCKytU4546Q== X-Received: by 2002:a1c:3142:: with SMTP id x63mr12801199wmx.62.1594287856715; Thu, 09 Jul 2020 02:44:16 -0700 (PDT) Received: from google.com ([81.6.44.51]) by smtp.gmail.com with ESMTPSA id w17sm4761445wra.42.2020.07.09.02.44.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2020 02:44:16 -0700 (PDT) From: KP Singh X-Google-Original-From: KP Singh Date: Thu, 9 Jul 2020 11:44:14 +0200 To: kernel test robot Cc: KP Singh , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-security-module@vger.kernel.org, kbuild-all@lists.01.org, Alexei Starovoitov , Daniel Borkmann , Paul Turner , Jann Horn , Florent Revest Subject: Re: [PATCH bpf-next v3 2/4] bpf: Implement bpf_local_storage for inodes Message-ID: <20200709094414.GB3743174@google.com> References: <20200709005654.3324272-3-kpsingh@chromium.org> <202007091250.vqzrSanp%lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202007091250.vqzrSanp%lkp@intel.com> Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On 09-Jul 12:37, kernel test robot wrote: > Hi KP, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on bpf-next/master] > > url: https://github.com/0day-ci/linux/commits/KP-Singh/Generalizing-bpf_local_storage/20200709-085810 > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master > config: mips-allyesconfig (attached as .config) > compiler: mips-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > >> kernel/bpf/bpf_inode_storage.c:274:17: warning: no previous prototype for 'inode_storage_map_alloc' [-Wmissing-prototypes] > 274 | struct bpf_map *inode_storage_map_alloc(union bpf_attr *attr) > | ^~~~~~~~~~~~~~~~~~~~~~~ > >> kernel/bpf/bpf_inode_storage.c:286:6: warning: no previous prototype for 'inode_storage_map_free' [-Wmissing-prototypes] > 286 | void inode_storage_map_free(struct bpf_map *map) > | ^~~~~~~~~~~~~~~~~~~~~~ Thanks! Should have been static. Fixed these. Will send a v4 with these fixes. - KP > > vim +/inode_storage_map_alloc +274 kernel/bpf/bpf_inode_storage.c > > 273 > > 274 struct bpf_map *inode_storage_map_alloc(union bpf_attr *attr) > 275 { > 276 struct bpf_local_storage_map *smap; > 277 > 278 smap = bpf_local_storage_map_alloc(attr); > 279 if (IS_ERR(smap)) > 280 return ERR_CAST(smap); > 281 > 282 smap->cache_idx = cache_idx_get_inode(); > 283 return &smap->map; > 284 } > 285 > > 286 void inode_storage_map_free(struct bpf_map *map) > 287 { > 288 struct bpf_local_storage_map *smap; > 289 > 290 smap = (struct bpf_local_storage_map *)map; > 291 cache_idx_free_inode(smap->cache_idx); > 292 bpf_local_storage_map_free(smap); > 293 } > 294 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org