From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A006CC433E2 for ; Tue, 14 Jul 2020 21:38:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AE3920656 for ; Tue, 14 Jul 2020 21:38:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="a/bS0RLh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728099AbgGNViP (ORCPT ); Tue, 14 Jul 2020 17:38:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726710AbgGNViO (ORCPT ); Tue, 14 Jul 2020 17:38:14 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7816FC08C5C1 for ; Tue, 14 Jul 2020 14:38:14 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id 207so8188859pfu.3 for ; Tue, 14 Jul 2020 14:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kBZyCcCmpqlqMqsIRaCWhuIM19zS4zfakl+jOrhjE68=; b=a/bS0RLhvJ42yObBQpWU7RQa+G5uNb2e0zU2vIxVYbKgCuhuVCePOZGoJtjvmwd7iN xmKjxlDlfNIw1CAvsEm1szrJz74LLht0/WrPFkETS5x0dnr7wky6Use55EWzyo1YbgMf wB0RHcDtBRksPGUwkP02h4mG8W2IaiPO+VB6c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kBZyCcCmpqlqMqsIRaCWhuIM19zS4zfakl+jOrhjE68=; b=VYfI51EuDBW4HR6iLi9WSs17L5Fc1snb5dnKUP7M0yQdoFFj0LRsBIhtkylR064aPp KkJWu8izXtNPpnqtju0NcKwXjSYrJCQFdtLVR4lA86kuJeIa+bZ8ClrfJYKypU/1aZxt 6RYoPTrUS3BM5JZrZjva9Pk4t8iyy3K6HyHS/To32jFx57I9/lzvyAnoJapntcmI659I VnFqXSF/3HA3mkqkeYHbvjIkvEKO7G7RyJK0Dyv63G1kzyq1wxcA6N4F/nFdbNaKTcxe edYqrPbru7nHJa2NN0BqHFYyriPrNXtpt+orXWK5oRs7MJ3l2pZunVlmjdGYeAS+Aw/v 4EzQ== X-Gm-Message-State: AOAM533w218x0d2E+wdcBSkdjZU6pdOQNJfoR2p+CjBuerlkWs/Xb3M5 EhI8qHZ34wjEcqk5k4EceaoIYA== X-Google-Smtp-Source: ABdhPJwFFznkEcbi8FULWjz22UCjJ7P9pQh+fwuMJMUGDuP9MkVzkem4ifewJtwGQEQdhFq/4ppcLQ== X-Received: by 2002:aa7:818e:: with SMTP id g14mr6043210pfi.27.1594762694075; Tue, 14 Jul 2020 14:38:14 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i128sm123203pfe.74.2020.07.14.14.38.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 14:38:13 -0700 (PDT) Date: Tue, 14 Jul 2020 14:38:12 -0700 From: Kees Cook To: "Eric W. Biederman" Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Andy Lutomirski , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Al Viro , Luis Chamberlain , linux-fsdevel@vger.kernel.org, Tetsuo Handa , linux-security-module@vger.kernel.org, "Serge E. Hallyn" , James Morris , Kentaro Takeda , Casey Schaufler , John Johansen , Christoph Hellwig Subject: Re: [PATCH 1/7] exec: Remove unnecessary spaces from binfmts.h Message-ID: <202007141438.68F0CEDCE6@keescook> References: <871rle8bw2.fsf@x220.int.ebiederm.org> <87v9iq6x9x.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87v9iq6x9x.fsf@x220.int.ebiederm.org> Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Tue, Jul 14, 2020 at 08:28:42AM -0500, Eric W. Biederman wrote: > > The general convention in the linux kernel is to define a pointer > member as "type *name". The declaration of struct linux_binprm has > several pointer defined as "type * name". Update them to the > form of "type *name" for consistency. > > Suggested-by: Kees Cook > Signed-off-by: "Eric W. Biederman" Reviewed-by: Kees Cook -- Kees Cook