* [PATCH net-next] netlabel: Fix some kernel-doc warnings
@ 2020-09-08 14:05 Wang Hai
2020-09-08 21:23 ` Paul Moore
2020-09-09 3:04 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Wang Hai @ 2020-09-08 14:05 UTC (permalink / raw)
To: paul, davem, kuba; +Cc: netdev, linux-kernel, linux-security-module
Fixes the following W=1 kernel build warning(s):
net/netlabel/netlabel_calipso.c:438: warning: Excess function parameter 'audit_secid' description in 'calipso_doi_remove'
net/netlabel/netlabel_calipso.c:605: warning: Excess function parameter 'reg' description in 'calipso_req_delattr'
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
net/netlabel/netlabel_calipso.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/netlabel/netlabel_calipso.c b/net/netlabel/netlabel_calipso.c
index 249da67d50a2..1a98247ab148 100644
--- a/net/netlabel/netlabel_calipso.c
+++ b/net/netlabel/netlabel_calipso.c
@@ -426,7 +426,7 @@ void calipso_doi_free(struct calipso_doi *doi_def)
/**
* calipso_doi_remove - Remove an existing DOI from the CALIPSO protocol engine
* @doi: the DOI value
- * @audit_secid: the LSM secid to use in the audit message
+ * @audit_info: NetLabel audit information
*
* Description:
* Removes a DOI definition from the CALIPSO engine. The NetLabel routines will
@@ -595,7 +595,7 @@ int calipso_req_setattr(struct request_sock *req,
/**
* calipso_req_delattr - Delete the CALIPSO option from a request socket
- * @reg: the request socket
+ * @req: the request socket
*
* Description:
* Removes the CALIPSO option from a request socket, if present.
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] netlabel: Fix some kernel-doc warnings
2020-09-08 14:05 [PATCH net-next] netlabel: Fix some kernel-doc warnings Wang Hai
@ 2020-09-08 21:23 ` Paul Moore
2020-09-09 3:04 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Paul Moore @ 2020-09-08 21:23 UTC (permalink / raw)
To: Wang Hai; +Cc: davem, kuba, netdev, linux-kernel, linux-security-module
On Tue, Sep 8, 2020 at 10:09 AM Wang Hai <wanghai38@huawei.com> wrote:
>
> Fixes the following W=1 kernel build warning(s):
>
> net/netlabel/netlabel_calipso.c:438: warning: Excess function parameter 'audit_secid' description in 'calipso_doi_remove'
> net/netlabel/netlabel_calipso.c:605: warning: Excess function parameter 'reg' description in 'calipso_req_delattr'
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
> net/netlabel/netlabel_calipso.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Looks good to me, thanks.
Acked-by: Paul Moore <paul@paul-moore.com>
> diff --git a/net/netlabel/netlabel_calipso.c b/net/netlabel/netlabel_calipso.c
> index 249da67d50a2..1a98247ab148 100644
> --- a/net/netlabel/netlabel_calipso.c
> +++ b/net/netlabel/netlabel_calipso.c
> @@ -426,7 +426,7 @@ void calipso_doi_free(struct calipso_doi *doi_def)
> /**
> * calipso_doi_remove - Remove an existing DOI from the CALIPSO protocol engine
> * @doi: the DOI value
> - * @audit_secid: the LSM secid to use in the audit message
> + * @audit_info: NetLabel audit information
> *
> * Description:
> * Removes a DOI definition from the CALIPSO engine. The NetLabel routines will
> @@ -595,7 +595,7 @@ int calipso_req_setattr(struct request_sock *req,
>
> /**
> * calipso_req_delattr - Delete the CALIPSO option from a request socket
> - * @reg: the request socket
> + * @req: the request socket
> *
> * Description:
> * Removes the CALIPSO option from a request socket, if present.
> --
> 2.17.1
>
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] netlabel: Fix some kernel-doc warnings
2020-09-08 14:05 [PATCH net-next] netlabel: Fix some kernel-doc warnings Wang Hai
2020-09-08 21:23 ` Paul Moore
@ 2020-09-09 3:04 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-09-09 3:04 UTC (permalink / raw)
To: wanghai38; +Cc: paul, kuba, netdev, linux-kernel, linux-security-module
From: Wang Hai <wanghai38@huawei.com>
Date: Tue, 8 Sep 2020 22:05:43 +0800
> Fixes the following W=1 kernel build warning(s):
>
> net/netlabel/netlabel_calipso.c:438: warning: Excess function parameter 'audit_secid' description in 'calipso_doi_remove'
> net/netlabel/netlabel_calipso.c:605: warning: Excess function parameter 'reg' description in 'calipso_req_delattr'
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-09 3:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-08 14:05 [PATCH net-next] netlabel: Fix some kernel-doc warnings Wang Hai
2020-09-08 21:23 ` Paul Moore
2020-09-09 3:04 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).