From: peterz@infradead.org
To: "Christian Göttsche" <cgzones@googlemail.com>
Cc: linux-kernel@vger.kernel.org, selinux@vger.kernel.org,
linux-security-module@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>
Subject: Re: [RFC PATCH] sched: only issue an audit on privileged operation
Date: Tue, 8 Sep 2020 12:25:37 +0200 [thread overview]
Message-ID: <20200908102537.GU2674@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200904160031.6444-1-cgzones@googlemail.com>
On Fri, Sep 04, 2020 at 06:00:31PM +0200, Christian Göttsche wrote:
> sched_setattr(2) does via kernel/sched/core.c:__sched_setscheduler()
> issue a CAP_SYS_NICE audit event unconditionally, even when the requested
> operation does not require that capability / is un-privileged.
>
> Perform privilged/unprivileged catigorization first and perform a
> capable test only if needed.
>
> Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
> ---
> kernel/sched/core.c | 65 ++++++++++++++++++++++++++++++++-------------
> 1 file changed, 47 insertions(+), 18 deletions(-)
So who sodding cares about audit, and why is that a reason to make a
trainwreck of code?
next prev parent reply other threads:[~2020-09-08 10:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-04 16:00 [RFC PATCH] sched: only issue an audit on privileged operation Christian Göttsche
2020-09-08 10:25 ` peterz [this message]
2020-09-08 11:28 ` Ondrej Mosnacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908102537.GU2674@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bsegall@google.com \
--cc=cgzones@googlemail.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=selinux@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox