From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 831C9C5517A for ; Mon, 2 Nov 2020 13:23:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B19E2227F for ; Mon, 2 Nov 2020 13:23:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727358AbgKBNXu (ORCPT ); Mon, 2 Nov 2020 08:23:50 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:48567 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbgKBNXu (ORCPT ); Mon, 2 Nov 2020 08:23:50 -0500 Received: from ip5f5af0a0.dynamic.kabel-deutschland.de ([95.90.240.160] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kZZoC-00072k-J9; Mon, 02 Nov 2020 13:23:40 +0000 Date: Mon, 2 Nov 2020 14:23:38 +0100 From: Christian Brauner To: Christoph Hellwig Cc: Alexander Viro , linux-fsdevel@vger.kernel.org, John Johansen , James Morris , Mimi Zohar , Dmitry Kasatkin , Stephen Smalley , Casey Schaufler , Arnd Bergmann , Andreas Dilger , OGAWA Hirofumi , Geoffrey Thomas , Mrunal Patel , Josh Triplett , Andy Lutomirski , Amir Goldstein , Miklos Szeredi , Theodore Tso , Alban Crequy , Tycho Andersen , David Howells , James Bottomley , Jann Horn , Seth Forshee , St??phane Graber , Aleksa Sarai , Lennart Poettering , "Eric W. Biederman" , smbarber@chromium.org, Phil Estes , Serge Hallyn , Kees Cook , Todd Kjos , Jonathan Corbet , containers@lists.linux-foundation.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, linux-ext4@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-audit@redhat.com, linux-integrity@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH 07/34] capability: handle idmapped mounts Message-ID: <20201102132338.ocq7z4oyn3aholi4@wittgenstein> References: <20201029003252.2128653-1-christian.brauner@ubuntu.com> <20201029003252.2128653-8-christian.brauner@ubuntu.com> <20201101144809.GE23378@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201101144809.GE23378@infradead.org> Precedence: bulk List-ID: On Sun, Nov 01, 2020 at 02:48:09PM +0000, Christoph Hellwig wrote: > > /** > > * capable_wrt_inode_uidgid - Check nsown_capable and uid and gid mapped > > * @inode: The inode in question > > @@ -501,9 +513,7 @@ bool privileged_wrt_inode_uidgid(struct user_namespace *ns, const struct inode * > > */ > > bool capable_wrt_inode_uidgid(const struct inode *inode, int cap) > > { > > + return capable_wrt_mapped_inode_uidgid(&init_user_ns, inode, cap); > > } > > EXPORT_SYMBOL(capable_wrt_inode_uidgid); > > Please avoid these silly wrappers and just switch all callers to pass > the namespaces instead of creating boilerplate code. Same for the other > functions where you do this even even worse the method calls. Christoph, Thanks for the review! Ok, so I'll switch: - all helpers to take an additional argument (capable_wrt_inode_uidgid()/inode_permission()/vfs_*() etc.) - all inode method calls to take an additional argument (I assume that's what you're referring to: ->create()/->mknod()/->mkdir() etc.) I've always assumed that this is what we'd be doing in the end anyway (I've mentioned it in the commit message for the inode_operations method's. This will be a bit of work but we can get that done!)