From: kernel test robot <lkp@intel.com>
To: Casey Schaufler <casey@schaufler-ca.com>,
casey.schaufler@intel.com, jmorris@namei.org,
linux-security-module@vger.kernel.org, selinux@vger.kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
casey@schaufler-ca.com, linux-audit@redhat.com,
keescook@chromium.org, john.johansen@canonical.com,
penguin-kernel@i-love.sakura.ne.jp, paul@paul-moore.com
Subject: Re: [PATCH v22 20/23] Audit: Add new record for multiple process LSM attributes
Date: Thu, 5 Nov 2020 17:31:36 +0800 [thread overview]
Message-ID: <202011051723.7Vfnebfu-lkp@intel.com> (raw)
In-Reply-To: <20201105004924.11651-21-casey@schaufler-ca.com>
[-- Attachment #1: Type: text/plain, Size: 7301 bytes --]
Hi Casey,
I love your patch! Perhaps something to improve:
[auto build test WARNING on nf-next/master]
[also build test WARNING on nf/master linus/master v5.10-rc2 next-20201104]
[cannot apply to security/next-testing]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Casey-Schaufler/LSM-Module-stacking-for-AppArmor/20201105-091817
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: arm-randconfig-r024-20201104 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 09ec07827b1128504457a93dee80b2ceee1af600)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://github.com/0day-ci/linux/commit/3fc93335d8a4090601fe221c305017ca73c23c61
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Casey-Schaufler/LSM-Module-stacking-for-AppArmor/20201105-091817
git checkout 3fc93335d8a4090601fe221c305017ca73c23c61
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
In file included from kernel/audit.c:51:
include/linux/audit.h:585:1: error: expected external declaration
+static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
^
kernel/audit.c:393:12: error: implicit declaration of function 'audit_alloc_for_lsm' [-Werror,-Wimplicit-function-declaration]
context = audit_alloc_for_lsm(GFP_KERNEL);
^
kernel/audit.c:393:12: note: did you mean 'audit_alloc_local'?
include/linux/audit.h:585:38: note: 'audit_alloc_local' declared here
+static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
^
>> kernel/audit.c:393:10: warning: incompatible integer to pointer conversion assigning to 'struct audit_context *' from 'int' [-Wint-conversion]
context = audit_alloc_for_lsm(GFP_KERNEL);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/audit.c:1357:15: error: implicit declaration of function 'audit_alloc_for_lsm' [-Werror,-Wimplicit-function-declaration]
lcontext = audit_alloc_for_lsm(GFP_KERNEL);
^
kernel/audit.c:1357:13: warning: incompatible integer to pointer conversion assigning to 'struct audit_context *' from 'int' [-Wint-conversion]
lcontext = audit_alloc_for_lsm(GFP_KERNEL);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/audit.c:1560:12: error: implicit declaration of function 'audit_alloc_for_lsm' [-Werror,-Wimplicit-function-declaration]
context = audit_alloc_for_lsm(GFP_KERNEL);
^
kernel/audit.c:1560:10: warning: incompatible integer to pointer conversion assigning to 'struct audit_context *' from 'int' [-Wint-conversion]
context = audit_alloc_for_lsm(GFP_KERNEL);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
kernel/audit.c:1781:14: warning: no previous prototype for function 'audit_serial' [-Wmissing-prototypes]
unsigned int audit_serial(void)
^
kernel/audit.c:1781:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
unsigned int audit_serial(void)
^
static
kernel/audit.c:2294:12: error: implicit declaration of function 'audit_alloc_for_lsm' [-Werror,-Wimplicit-function-declaration]
context = audit_alloc_for_lsm(GFP_KERNEL);
^
kernel/audit.c:2294:10: warning: incompatible integer to pointer conversion assigning to 'struct audit_context *' from 'int' [-Wint-conversion]
context = audit_alloc_for_lsm(GFP_KERNEL);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 warnings and 5 errors generated.
--
In file included from kernel/auditfilter.c:12:
include/linux/audit.h:585:1: error: expected external declaration
+static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
^
kernel/auditfilter.c:1107:12: error: implicit declaration of function 'audit_alloc_for_lsm' [-Werror,-Wimplicit-function-declaration]
context = audit_alloc_for_lsm(GFP_KERNEL);
^
kernel/auditfilter.c:1107:12: note: did you mean 'audit_alloc_local'?
include/linux/audit.h:585:38: note: 'audit_alloc_local' declared here
+static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
^
>> kernel/auditfilter.c:1107:10: warning: incompatible integer to pointer conversion assigning to 'struct audit_context *' from 'int' [-Wint-conversion]
context = audit_alloc_for_lsm(GFP_KERNEL);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 2 errors generated.
--
In file included from net/netlabel/netlabel_user.c:20:
include/linux/audit.h:585:1: error: expected external declaration
+static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
^
net/netlabel/netlabel_user.c:93:14: error: implicit declaration of function 'audit_alloc_for_lsm' [-Werror,-Wimplicit-function-declaration]
audit_ctx = audit_alloc_for_lsm(GFP_ATOMIC);
^
net/netlabel/netlabel_user.c:93:14: note: did you mean 'audit_alloc_local'?
include/linux/audit.h:585:38: note: 'audit_alloc_local' declared here
+static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
^
>> net/netlabel/netlabel_user.c:93:12: warning: incompatible integer to pointer conversion assigning to 'struct audit_context *' from 'int' [-Wint-conversion]
audit_ctx = audit_alloc_for_lsm(GFP_ATOMIC);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning and 2 errors generated.
vim +393 kernel/audit.c
385
386 static int audit_log_config_change(char *function_name, u32 new, u32 old,
387 int allow_changes)
388 {
389 struct audit_context *context;
390 struct audit_buffer *ab;
391 int rc = 0;
392
> 393 context = audit_alloc_for_lsm(GFP_KERNEL);
394 ab = audit_log_start(context, GFP_KERNEL, AUDIT_CONFIG_CHANGE);
395 if (unlikely(!ab))
396 return rc;
397 audit_log_format(ab, "op=set %s=%u old=%u ", function_name, new, old);
398 audit_log_session_info(ab);
399 rc = audit_log_task_context(ab);
400 if (rc)
401 allow_changes = 0; /* Something weird, deny request */
402 audit_log_format(ab, " res=%d", allow_changes);
403 audit_log_end_local(ab, context);
404 return rc;
405 }
406
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 36844 bytes --]
next prev parent reply other threads:[~2020-11-05 9:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201105004924.11651-1-casey.ref@schaufler-ca.com>
2020-11-05 0:49 ` [PATCH v22 00/23] LSM: Module stacking for AppArmor Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 01/23] LSM: Infrastructure management of the sock security Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 02/23] LSM: Create and manage the lsmblob data structure Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 03/23] LSM: Use lsmblob in security_audit_rule_match Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 04/23] LSM: Use lsmblob in security_kernel_act_as Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 05/23] LSM: Use lsmblob in security_secctx_to_secid Casey Schaufler
2020-11-10 6:53 ` James Morris
2020-11-05 0:49 ` [PATCH v22 06/23] LSM: Use lsmblob in security_secid_to_secctx Casey Schaufler
2020-11-10 6:56 ` James Morris
2020-11-05 0:49 ` [PATCH v22 07/23] LSM: Use lsmblob in security_ipc_getsecid Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 08/23] LSM: Use lsmblob in security_task_getsecid Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 09/23] LSM: Use lsmblob in security_inode_getsecid Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 10/23] LSM: Use lsmblob in security_cred_getsecid Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 11/23] IMA: Change internal interfaces to use lsmblobs Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 12/23] LSM: Specify which LSM to display Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 13/23] LSM: Ensure the correct LSM context releaser Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 14/23] LSM: Use lsmcontext in security_secid_to_secctx Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 15/23] LSM: Use lsmcontext in security_inode_getsecctx Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 16/23] LSM: security_secid_to_secctx in netlink netfilter Casey Schaufler
2020-11-10 13:37 ` Pablo Neira Ayuso
2020-11-10 19:26 ` James Morris
2020-11-05 0:49 ` [PATCH v22 17/23] NET: Store LSM netlabel data in a lsmblob Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 18/23] LSM: Verify LSM display sanity in binder Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 19/23] audit: add support for non-syscall auxiliary records Casey Schaufler
2020-11-16 0:13 ` kernel test robot
2020-11-05 0:49 ` [PATCH v22 20/23] Audit: Add new record for multiple process LSM attributes Casey Schaufler
2020-11-05 9:31 ` kernel test robot [this message]
2020-11-11 4:45 ` kernel test robot
2020-11-11 6:37 ` kernel test robot
2020-11-05 0:49 ` [PATCH v22 21/23] Audit: Add a new record for multiple object " Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 22/23] LSM: Add /proc attr entry for full LSM context Casey Schaufler
2020-11-05 0:49 ` [PATCH v22 23/23] AppArmor: Remove the exclusive flag Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202011051723.7Vfnebfu-lkp@intel.com \
--to=lkp@intel.com \
--cc=casey.schaufler@intel.com \
--cc=casey@schaufler-ca.com \
--cc=clang-built-linux@googlegroups.com \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=kbuild-all@lists.01.org \
--cc=keescook@chromium.org \
--cc=linux-audit@redhat.com \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).