linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Casey Schaufler <casey@schaufler-ca.com>,
	casey.schaufler@intel.com, jmorris@namei.org,
	linux-security-module@vger.kernel.org, selinux@vger.kernel.org
Cc: kbuild-all@lists.01.org, casey@schaufler-ca.com,
	linux-audit@redhat.com, keescook@chromium.org,
	john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp,
	paul@paul-moore.com
Subject: Re: [PATCH v22 20/23] Audit: Add new record for multiple process LSM attributes
Date: Wed, 11 Nov 2020 12:45:30 +0800	[thread overview]
Message-ID: <202011111201.tleMU64S-lkp@intel.com> (raw)
In-Reply-To: <20201105004924.11651-21-casey@schaufler-ca.com>

[-- Attachment #1: Type: text/plain, Size: 3952 bytes --]

Hi Casey,

I love your patch! Yet something to improve:

[auto build test ERROR on nf-next/master]
[also build test ERROR on nf/master linus/master v5.10-rc3 next-20201110]
[cannot apply to security/next-testing]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Casey-Schaufler/LSM-Module-stacking-for-AppArmor/20201105-091817
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: powerpc-allnoconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/3fc93335d8a4090601fe221c305017ca73c23c61
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Casey-Schaufler/LSM-Module-stacking-for-AppArmor/20201105-091817
        git checkout 3fc93335d8a4090601fe221c305017ca73c23c61
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/powerpc/kernel/ptrace/ptrace.c:20:
   include/linux/audit.h:585:1: error: expected identifier or '(' before '+' token
     585 | +static inline struct audit_context *audit_alloc_local(gfp_t gfpflags)
         | ^
>> include/linux/audit.h:261:13: error: 'audit_log_lsm' defined but not used [-Werror=unused-function]
     261 | static void audit_log_lsm(struct audit_context *context)
         |             ^~~~~~~~~~~~~
   cc1: all warnings being treated as errors

vim +/audit_log_lsm +261 include/linux/audit.h

   216	
   217	#else /* CONFIG_AUDIT */
   218	static inline __printf(4, 5)
   219	void audit_log(struct audit_context *ctx, gfp_t gfp_mask, int type,
   220		       const char *fmt, ...)
   221	{ }
   222	static inline struct audit_buffer *audit_log_start(struct audit_context *ctx,
   223							   gfp_t gfp_mask, int type)
   224	{
   225		return NULL;
   226	}
   227	static inline __printf(2, 3)
   228	void audit_log_format(struct audit_buffer *ab, const char *fmt, ...)
   229	{ }
   230	static inline void audit_log_end(struct audit_buffer *ab)
   231	{ }
   232	static inline void audit_log_end_local(struct audit_buffer *ab,
   233					       struct audit_context *context)
   234	{ }
   235	static inline void audit_log_n_hex(struct audit_buffer *ab,
   236					   const unsigned char *buf, size_t len)
   237	{ }
   238	static inline void audit_log_n_string(struct audit_buffer *ab,
   239					      const char *buf, size_t n)
   240	{ }
   241	static inline void  audit_log_n_untrustedstring(struct audit_buffer *ab,
   242							const char *string, size_t n)
   243	{ }
   244	static inline void audit_log_untrustedstring(struct audit_buffer *ab,
   245						     const char *string)
   246	{ }
   247	static inline void audit_log_d_path(struct audit_buffer *ab,
   248					    const char *prefix,
   249					    const struct path *path)
   250	{ }
   251	static inline void audit_log_key(struct audit_buffer *ab, char *key)
   252	{ }
   253	static inline void audit_log_path_denied(int type, const char *operation)
   254	{ }
   255	static inline int audit_log_task_context(struct audit_buffer *ab)
   256	{
   257		return 0;
   258	}
   259	static inline void audit_log_task_info(struct audit_buffer *ab)
   260	{ }
 > 261	static void audit_log_lsm(struct audit_context *context)
   262	{ }
   263	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 6477 bytes --]

  parent reply	other threads:[~2020-11-11  4:46 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20201105004924.11651-1-casey.ref@schaufler-ca.com>
2020-11-05  0:49 ` [PATCH v22 00/23] LSM: Module stacking for AppArmor Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 01/23] LSM: Infrastructure management of the sock security Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 02/23] LSM: Create and manage the lsmblob data structure Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 03/23] LSM: Use lsmblob in security_audit_rule_match Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 04/23] LSM: Use lsmblob in security_kernel_act_as Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 05/23] LSM: Use lsmblob in security_secctx_to_secid Casey Schaufler
2020-11-10  6:53     ` James Morris
2020-11-05  0:49   ` [PATCH v22 06/23] LSM: Use lsmblob in security_secid_to_secctx Casey Schaufler
2020-11-10  6:56     ` James Morris
2020-11-05  0:49   ` [PATCH v22 07/23] LSM: Use lsmblob in security_ipc_getsecid Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 08/23] LSM: Use lsmblob in security_task_getsecid Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 09/23] LSM: Use lsmblob in security_inode_getsecid Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 10/23] LSM: Use lsmblob in security_cred_getsecid Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 11/23] IMA: Change internal interfaces to use lsmblobs Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 12/23] LSM: Specify which LSM to display Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 13/23] LSM: Ensure the correct LSM context releaser Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 14/23] LSM: Use lsmcontext in security_secid_to_secctx Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 15/23] LSM: Use lsmcontext in security_inode_getsecctx Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 16/23] LSM: security_secid_to_secctx in netlink netfilter Casey Schaufler
2020-11-10 13:37     ` Pablo Neira Ayuso
2020-11-10 19:26       ` James Morris
2020-11-05  0:49   ` [PATCH v22 17/23] NET: Store LSM netlabel data in a lsmblob Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 18/23] LSM: Verify LSM display sanity in binder Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 19/23] audit: add support for non-syscall auxiliary records Casey Schaufler
2020-11-16  0:13     ` kernel test robot
2020-11-05  0:49   ` [PATCH v22 20/23] Audit: Add new record for multiple process LSM attributes Casey Schaufler
2020-11-05  9:31     ` kernel test robot
2020-11-11  4:45     ` kernel test robot [this message]
2020-11-11  6:37     ` kernel test robot
2020-11-05  0:49   ` [PATCH v22 21/23] Audit: Add a new record for multiple object " Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 22/23] LSM: Add /proc attr entry for full LSM context Casey Schaufler
2020-11-05  0:49   ` [PATCH v22 23/23] AppArmor: Remove the exclusive flag Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202011111201.tleMU64S-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=casey.schaufler@intel.com \
    --cc=casey@schaufler-ca.com \
    --cc=jmorris@namei.org \
    --cc=john.johansen@canonical.com \
    --cc=kbuild-all@lists.01.org \
    --cc=keescook@chromium.org \
    --cc=linux-audit@redhat.com \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).