From: Kees Cook <keescook@chromium.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Hulk Robot <hulkci@huawei.com>, James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mimi Zohar <zohar@linux.ibm.com>,
Scott Branden <scott.branden@broadcom.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Tushar Sugandhi <tusharsu@linux.microsoft.com>,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH -next] integrity: Make function integrity_add_key() static
Date: Wed, 10 Feb 2021 12:52:57 -0800 [thread overview]
Message-ID: <202102101252.12F104E44@keescook> (raw)
In-Reply-To: <20210210080131.1209889-1-weiyongjun1@huawei.com>
On Wed, Feb 10, 2021 at 08:01:31AM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> security/integrity/digsig.c:146:12: warning:
> symbol 'integrity_add_key' was not declared. Should it be static?
>
> This function is not used outside of digsig.c, so this
> commit marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2021-02-10 20:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 8:01 [PATCH -next] integrity: Make function integrity_add_key() static Wei Yongjun
2021-02-10 20:52 ` Kees Cook [this message]
2021-02-12 16:11 ` Nayna
2021-02-12 16:21 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202102101252.12F104E44@keescook \
--to=keescook@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=hulkci@huawei.com \
--cc=jmorris@namei.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=scott.branden@broadcom.com \
--cc=serge@hallyn.com \
--cc=tusharsu@linux.microsoft.com \
--cc=weiyongjun1@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).