Re: [PATCH v30 02/12] landlock: Add ruleset and domain management

Mickaël Salaün
2021-03-25T09:30:05Z

On 24/03/2021 21:31, James Morris wrote:
> On Fri, 19 Mar 2021, Mickaël Salaün wrote:
>
>>
>>>> Cc: Kees Cook <keescook@chromium.org>
>>>> Signed-off-by: Mickaël Salaün <mic@linux.microsoft.com>
>>>> Acked-by: Serge Hallyn <serge@hallyn.com>
>>>> Link: https://lore.kernel.org/r/20210316204252.427806-3-mic@digikod.net
>>>
>>> (Aside: you appear to be self-adding your Link: tags -- AIUI, this is
>>> normally done by whoever pulls your series. I've only seen Link: tags
>>> added when needing to refer to something else not included in the
>>> series.)
>>
>> It is an insurance to not lose history. :)
>
> How will history be lost? The code is in the repo and discussions can
> easily be found by searching for subjects or message IDs.

The (full and ordered) history may be hard to find without any
Message-ID in commit messages. The Lore links keep that information (in
the commit message) and redirect to the related archived email thread,
which is very handy. For instance, Linus can rely on those links to
judge the quality of a patch:
https://lore.kernel.org/lkml/CAHk-=wh7xY3UF7zEc0BNVNjOox59jYBW-Gfi7=emm+BXPWc6nQ@mail.gmail.com/

>
> Is anyone else doing this self linking?
>

I don't know, but it doesn't hurt. This way, if you're using git am
without b4 am -l (or forgot to add links manually), the history is still
pointed out by these self-reference links. I find it convenient and it
is a safeguard to not forget them, no matter who takes the patches.