From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07256C43460 for ; Wed, 31 Mar 2021 17:51:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFE9560FE3 for ; Wed, 31 Mar 2021 17:51:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234511AbhCaRum (ORCPT ); Wed, 31 Mar 2021 13:50:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234576AbhCaRu1 (ORCPT ); Wed, 31 Mar 2021 13:50:27 -0400 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EF92C061762 for ; Wed, 31 Mar 2021 10:50:27 -0700 (PDT) Received: by mail-pj1-x1033.google.com with SMTP id x7-20020a17090a2b07b02900c0ea793940so1578900pjc.2 for ; Wed, 31 Mar 2021 10:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=fwPCJ0ln7XiN1Mgyh62R5lYieMyObsTHbG0RZrvRPwE=; b=OefcY/8KfUGCvJz0PF4h17nCzx8f0uaNcos4bTKX5FJPltpnno8jfg/iqcQ8GisI2O sHzAFk2S5lMRyMS6dPjFOX+nxDw6q0h8Yq+yTa5WONZV88VtK8jwKjKAtVpgtoDF0Mxi tENIdh63kVi4PxUTOmbdWQya7sFMLfNIU5yvU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=fwPCJ0ln7XiN1Mgyh62R5lYieMyObsTHbG0RZrvRPwE=; b=QrRRkdyHMaIOM0BUxmNtyYlR8mxh1nFcmupRAxaKQBAA+miILcaRjTcGehrToi+Hko C1U8iX3UDwMgI6x4f1BF5Q4DPcYSRQA0ROggmu4IL0hHwCm9lm4qZV2Dr0Tui35u+tVe hN28Wu1zYEs/+1F3Z1r3aVuUbSqxj6gJLNArdBTM8ReSM9pjhRxU7WKjOEvYAQ68vLZA AqqnU2QYVDbbl4J21IN/VILDQxvZ6r0xPUpdzdM6n043z2PRVMGGhU3PJPX1r+aoFFoy /ofHzptKtLod+bVICem+QY0oPVrRLgR2i24GS9X3IVlBINDmEDk3tkcTKgEiQnbdF9Jk 3Anw== X-Gm-Message-State: AOAM533o2bjrvtW8cEWAeMf+O8xk43mfKEqKGRVtNcwzEInfFqbn3XFi 00s31doRFqAD4ab5hmMJFMig7Q== X-Google-Smtp-Source: ABdhPJxLFRk32S5JAWcjXEQfVNlU3MgfcnfPT07dz6zmQQRJYgHlVguRXJRY5mE9rC3ZM2LThifa9g== X-Received: by 2002:a17:90a:c918:: with SMTP id v24mr4631376pjt.182.1617213026927; Wed, 31 Mar 2021 10:50:26 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q184sm2905798pfc.78.2021.03.31.10.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Mar 2021 10:50:26 -0700 (PDT) Date: Wed, 31 Mar 2021 10:50:25 -0700 From: Kees Cook To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: Jann Horn , Al Viro , Andrew Morton , Andy Lutomirski , Anton Ivanov , Arnd Bergmann , Casey Schaufler , David Howells , Jeff Dike , Jonathan Corbet , Michael Kerrisk , Richard Weinberger , Shuah Khan , Vincent Dagonneau , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-security-module@vger.kernel.org, x86@kernel.org, =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , James Morris , "Serge E . Hallyn" Subject: Re: [PATCH v31 07/12] landlock: Support filesystem access-control Message-ID: <202103311048.3D4D927961@keescook> References: <20210324191520.125779-1-mic@digikod.net> <20210324191520.125779-8-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: On Wed, Mar 31, 2021 at 07:33:50PM +0200, Mickaël Salaün wrote: > Jann, Kees, are you OK with this patch and the next one? I don't feel qualified to say it's using the VFS correctly, but given the extensive testing via gcov and syzkaller, I'm comfortable with it landing. I defer to James. :) -Kees -- Kees Cook