From: "Serge E. Hallyn" <serge@hallyn.com>
To: Baokun Li <libaokun1@huawei.com>
Cc: serge@hallyn.com, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, weiyongjun1@huawei.com,
yuehaibing@huawei.com, yangjihong1@huawei.com,
yukuai3@huawei.com
Subject: Re: [PATCH -next] capability: fix doc warnings in capability.c
Date: Mon, 7 Jun 2021 18:09:13 -0500 [thread overview]
Message-ID: <20210607230913.GA12581@mail.hallyn.com> (raw)
In-Reply-To: <20210605062602.678602-1-libaokun1@huawei.com>
On Sat, Jun 05, 2021 at 02:26:02PM +0800, Baokun Li wrote:
> Fixes the following W=1 kernel build warning(s):
>
> kernel/capability.c:490: warning: Function parameter or
> member 'mnt_userns' not described in 'privileged_wrt_inode_uidgid'
> kernel/capability.c:506: warning: Function parameter or
> member 'mnt_userns' not described in 'capable_wrt_inode_uidgid'
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> kernel/capability.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/capability.c b/kernel/capability.c
> index 46a361dde042..27a959aa897f 100644
> --- a/kernel/capability.c
> +++ b/kernel/capability.c
> @@ -480,6 +480,7 @@ EXPORT_SYMBOL(file_ns_capable);
> /**
> * privileged_wrt_inode_uidgid - Do capabilities in the namespace work over the inode?
> * @ns: The user namespace in question
> + * @mnt_userns: User namespace of the mount the inode was found from
> * @inode: The inode in question
> *
> * Return true if the inode uid and gid are within the namespace.
> @@ -495,6 +496,7 @@ bool privileged_wrt_inode_uidgid(struct user_namespace *ns,
> /**
> * capable_wrt_inode_uidgid - Check nsown_capable and uid and gid mapped
> * @inode: The inode in question
> + * @mnt_userns: User namespace of the mount the inode was found from
The mnt_userns comes before the inode in this fn.
> * @cap: The capability in question
> *
> * Return true if the current task has the given capability targeted at
> --
> 2.31.1
next prev parent reply other threads:[~2021-06-07 23:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 6:26 [PATCH -next] capability: fix doc warnings in capability.c Baokun Li
2021-06-07 23:09 ` Serge E. Hallyn [this message]
2021-06-08 1:14 ` libaokun (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210607230913.GA12581@mail.hallyn.com \
--to=serge@hallyn.com \
--cc=libaokun1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=yangjihong1@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).