From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 331D2C433EF for ; Tue, 7 Sep 2021 22:50:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C5E460E77 for ; Tue, 7 Sep 2021 22:50:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346933AbhIGWvs (ORCPT ); Tue, 7 Sep 2021 18:51:48 -0400 Received: from gate.crashing.org ([63.228.1.57]:34906 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344396AbhIGWvs (ORCPT ); Tue, 7 Sep 2021 18:51:48 -0400 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 187MgSFs013086; Tue, 7 Sep 2021 17:42:29 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 187MgRGq013085; Tue, 7 Sep 2021 17:42:27 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Tue, 7 Sep 2021 17:42:27 -0500 From: Segher Boessenkool To: Marco Elver Cc: Nick Desaulniers , Linus Torvalds , llvm@lists.linux.dev, LSM List , linux-toolchains@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , Guenter Roeck , Kees Cook , Mark Brown , Masahiro Yamada , Nathan Chancellor , Michal Marek , Andrew Morton , Vipin Sharma , Chris Down , Rasmus Villemoes , Daniel Borkmann , Vlastimil Babka , Linux Kbuild mailing list , Linux Kernel Mailing List Subject: Re: [PATCH] Revert "Enable '-Werror' by default for all kernel builds" Message-ID: <20210907224227.GL1583@gate.crashing.org> References: <20210907183843.33028-1-ndesaulniers@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Precedence: bulk List-ID: On Wed, Sep 08, 2021 at 12:14:19AM +0200, Marco Elver wrote: > Here's a datapoint: I had to disable CONFIG_WERROR on a bunch of syzbot > instances which started failing because of -Werror [1], because syzbot's > time is better spent on fuzzing, and having the odd warning in some > subsystem penalize fuzzing of the entire kernel is not appropriate. Similarly, I have to disable -Werror (which various archs and subsystems already use) whenever I test building the kernel with new toolchains. It is the biggest set of kernel patches I keep, already, since many years. I actually have good hopes that a centralised -Werror thing will make this easier :-) Maybe there can be an E=[01] kernel build flag to disable / enable CONFIG_WERROR? Something that will override it for just that command. This would make life easier for many use cases, while at the same time not being something that people can "forget" they did. Segher