From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9348CC433EF for ; Mon, 13 Sep 2021 10:02:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 787B460F25 for ; Mon, 13 Sep 2021 10:02:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238699AbhIMKDs (ORCPT ); Mon, 13 Sep 2021 06:03:48 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:59950 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238444AbhIMKDs (ORCPT ); Mon, 13 Sep 2021 06:03:48 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 25E301C0BA4; Mon, 13 Sep 2021 12:02:31 +0200 (CEST) Date: Mon, 13 Sep 2021 12:02:30 +0200 From: Pavel Machek To: Greg Kroah-Hartman Cc: Randy Dunlap , Linus Torvalds , Marco Elver , Nick Desaulniers , llvm@lists.linux.dev, LSM List , linux-toolchains@vger.kernel.org, Arnd Bergmann , Guenter Roeck , Kees Cook , Mark Brown , Masahiro Yamada , Nathan Chancellor , Michal Marek , Andrew Morton , Vipin Sharma , Chris Down , Rasmus Villemoes , Daniel Borkmann , Vlastimil Babka , Linux Kbuild mailing list , Linux Kernel Mailing List Subject: Re: [PATCH] Revert "Enable '-Werror' by default for all kernel builds" Message-ID: <20210913100230.GB11752@amd> References: <20210907183843.33028-1-ndesaulniers@google.com> <20210913093256.GA12225@amd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="St7VIuEGZ6dlpu13" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: --St7VIuEGZ6dlpu13 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > Do we really want developers treat warnings as errors? When the code > > is okay but some random version of gcc dislikes it... > >=20 > > Plus, there's question of stable. We already get ton of churn there > > ("this fixes random warning"). WERROR will only encourage that... >=20 > I will not be backporting this patch to older stable kernels, but I > _want_ to see stable builds build with no warnings. When we add > warnings, they are almost always things we need to fix up properly. Well, everyone _wants_ to see clean builds... unless the price is too high. > Over time, I have worked to reduce the number of build warnings in older > stable kernels. For newer versions of gcc, sometimes that is > impossible, but we are close... You clearly can't backport this patch, but for 5.16-stable, you'll have it in, and now warnings are same as errors... and I don't believe that's good idea for stable. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --St7VIuEGZ6dlpu13 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmE/IbYACgkQMOfwapXb+vKcjQCgsx/nkYPj+Zfb6WZVMcX1mNgO QQcAn0SIZwPJI7cQj6g6p75gp2KIo6FC =iJmG -----END PGP SIGNATURE----- --St7VIuEGZ6dlpu13--