From: Todd Kjos <tkjos@google.com>
To: gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
maco@android.com, christian@brauner.io, jmorris@namei.org,
serge@hallyn.com, paul@paul-moore.com,
stephen.smalley.work@gmail.com, eparis@parisplace.org,
keescook@chromium.org, jannh@google.com, jeffv@google.com,
zohar@linux.ibm.com, linux-security-module@vger.kernel.org,
selinux@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Cc: joel@joelfernandes.org, kernel-team@android.com,
Todd Kjos <tkjos@google.com>
Subject: [PATCH v4 0/3] binder: use cred instead of task for security context
Date: Wed, 6 Oct 2021 17:46:26 -0700 [thread overview]
Message-ID: <20211007004629.1113572-1-tkjos@google.com> (raw)
This series fixes the possible use of an incorrect security context
when checking selinux permissions, getting a security ID, or lookup
up the euid.
The previous behavior was to save the group_leader 'struct task_struct'
in binder_open() and using that to obtain security IDs or euids.
This has been shown to be unreliable, so this series instead saves the
'struct cred' of the task that called binder_open(). This cred is used
for these lookups instead of the task.
v1 and v2 of this series were a single patch "binder: use euid from"
cred instead of using task". During review, Stephen Smalley identified
two more related issues so the corresponding patches were added to
the series.
v3:
- add 2 patches to fix getsecid and euid
v4:
- fix minor checkpatch issues
- fix build-break for !CONFIG_SECURITY
Todd Kjos (3):
binder: use cred instead of task for selinux checks
binder: use cred instead of task for getsecid
binder: use euid from cred instead of using task
drivers/android/binder.c | 14 ++++++++------
drivers/android/binder_internal.h | 4 ++++
include/linux/lsm_hook_defs.h | 14 +++++++-------
include/linux/lsm_hooks.h | 14 +++++++-------
include/linux/security.h | 28 ++++++++++++++--------------
security/security.c | 14 +++++++-------
security/selinux/hooks.c | 48 +++++++++++++-----------------------------------
7 files changed, 60 insertions(+), 76 deletions(-)
next reply other threads:[~2021-10-07 0:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 0:46 Todd Kjos [this message]
2021-10-07 0:46 ` [PATCH v4 1/3] binder: use cred instead of task for selinux checks Todd Kjos
2021-10-07 0:46 ` [PATCH v4 2/3] binder: use cred instead of task for getsecid Todd Kjos
2021-10-11 21:33 ` Paul Moore
2021-10-11 21:59 ` Casey Schaufler
2021-10-11 23:10 ` Paul Moore
2021-10-12 9:41 ` Dan Carpenter
2021-10-12 14:13 ` Paul Moore
2021-10-07 0:46 ` [PATCH v4 3/3] binder: use euid from cred instead of using task Todd Kjos
2021-10-08 21:12 ` Paul Moore
2021-10-08 21:24 ` Todd Kjos
2021-10-11 21:39 ` Paul Moore
2021-10-11 23:39 ` Todd Kjos
2021-10-12 12:24 ` Stephen Smalley
2021-10-12 16:52 ` Todd Kjos
2021-10-08 21:25 ` Casey Schaufler
2021-10-11 21:34 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007004629.1113572-1-tkjos@google.com \
--to=tkjos@google.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=eparis@parisplace.org \
--cc=gregkh@linuxfoundation.org \
--cc=jannh@google.com \
--cc=jeffv@google.com \
--cc=jmorris@namei.org \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=maco@android.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=stephen.smalley.work@gmail.com \
--cc=tkjos@android.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).