From: Todd Kjos <tkjos@google.com>
To: gregkh@linuxfoundation.org, arve@android.com, tkjos@android.com,
maco@android.com, christian@brauner.io, jmorris@namei.org,
serge@hallyn.com, paul@paul-moore.com,
stephen.smalley.work@gmail.com, eparis@parisplace.org,
keescook@chromium.org, jannh@google.com, jeffv@google.com,
zohar@linux.ibm.com, linux-security-module@vger.kernel.org,
selinux@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Cc: joel@joelfernandes.org, kernel-team@android.com,
Todd Kjos <tkjos@google.com>,
stable@vger.kernel.org
Subject: [PATCH v4 3/3] binder: use euid from cred instead of using task
Date: Wed, 6 Oct 2021 17:46:29 -0700 [thread overview]
Message-ID: <20211007004629.1113572-4-tkjos@google.com> (raw)
In-Reply-To: <20211007004629.1113572-1-tkjos@google.com>
Set a transaction's sender_euid from the 'struct cred'
saved at binder_open() instead of looking up the euid
from the binder proc's 'struct task'. This ensures
the euid is associated with the security context that
of the task that opened binder.
Fixes: 457b9a6f09f0 ("Staging: android: add binder driver")
Signed-off-by: Todd Kjos <tkjos@google.com>
Suggested-by: Stephen Smalley <stephen.smalley.work@gmail.com>
Cc: stable@vger.kernel.org # 4.4+
---
v3: added this patch to series
drivers/android/binder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 989afd0804ca..26382e982c5e 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2711,7 +2711,7 @@ static void binder_transaction(struct binder_proc *proc,
t->from = thread;
else
t->from = NULL;
- t->sender_euid = task_euid(proc->tsk);
+ t->sender_euid = proc->cred->euid;
t->to_proc = target_proc;
t->to_thread = target_thread;
t->code = tr->code;
--
2.33.0.800.g4c38ced690-goog
next prev parent reply other threads:[~2021-10-07 0:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 0:46 [PATCH v4 0/3] binder: use cred instead of task for security context Todd Kjos
2021-10-07 0:46 ` [PATCH v4 1/3] binder: use cred instead of task for selinux checks Todd Kjos
2021-10-07 0:46 ` [PATCH v4 2/3] binder: use cred instead of task for getsecid Todd Kjos
2021-10-11 21:33 ` Paul Moore
2021-10-11 21:59 ` Casey Schaufler
2021-10-11 23:10 ` Paul Moore
2021-10-12 9:41 ` Dan Carpenter
2021-10-12 14:13 ` Paul Moore
2021-10-07 0:46 ` Todd Kjos [this message]
2021-10-08 21:12 ` [PATCH v4 3/3] binder: use euid from cred instead of using task Paul Moore
2021-10-08 21:24 ` Todd Kjos
2021-10-11 21:39 ` Paul Moore
2021-10-11 23:39 ` Todd Kjos
2021-10-12 12:24 ` Stephen Smalley
2021-10-12 16:52 ` Todd Kjos
2021-10-08 21:25 ` Casey Schaufler
2021-10-11 21:34 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007004629.1113572-4-tkjos@google.com \
--to=tkjos@google.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=eparis@parisplace.org \
--cc=gregkh@linuxfoundation.org \
--cc=jannh@google.com \
--cc=jeffv@google.com \
--cc=jmorris@namei.org \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=maco@android.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=stable@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
--cc=tkjos@android.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).