From: Kees Cook <keescook@chromium.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-hardening@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-doc@vger.kernel.org, Dan Li <ashimida@linux.alibaba.com>,
ardb@kernel.org, ojeda@kernel.org,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH 2/2] gcc-plugins: Remove cyc_complexity
Date: Wed, 20 Oct 2021 12:10:27 -0700 [thread overview]
Message-ID: <202110201209.A245EFB94@keescook> (raw)
In-Reply-To: <YXBWi/bCQoddzXB6@archlinux-ax161>
On Wed, Oct 20, 2021 at 10:48:59AM -0700, Nathan Chancellor wrote:
> On Wed, Oct 20, 2021 at 10:35:54AM -0700, Kees Cook wrote:
> > This plugin has no impact on the resulting binary, is disabled
> > under COMPILE_TEST, and is not enabled on any builds I'm aware of.
> > Additionally, given the clarified purpose of GCC plugins in the kernel,
> > remove cyc_complexity.
> >
> > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > Cc: Michal Marek <michal.lkml@markovi.net>
> > Cc: Nick Desaulniers <ndesaulniers@google.com>
> > Cc: Jonathan Corbet <corbet@lwn.net>
> > Cc: linux-hardening@vger.kernel.org
> > Cc: linux-kbuild@vger.kernel.org
> > Cc: linux-doc@vger.kernel.org
> > Signed-off-by: Kees Cook <keescook@chromium.org>
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
> One comment below.
>
> > ---
> > Documentation/kbuild/gcc-plugins.rst | 2 -
> > scripts/Makefile.gcc-plugins | 2 -
> > scripts/gcc-plugins/Kconfig | 16 -----
> > scripts/gcc-plugins/cyc_complexity_plugin.c | 69 ---------------------
> > 4 files changed, 89 deletions(-)
> > delete mode 100644 scripts/gcc-plugins/cyc_complexity_plugin.c
> >
> > diff --git a/Documentation/kbuild/gcc-plugins.rst b/Documentation/kbuild/gcc-plugins.rst
> > index 4b28c7a4032f..0ba76719f1b9 100644
> > --- a/Documentation/kbuild/gcc-plugins.rst
> > +++ b/Documentation/kbuild/gcc-plugins.rst
> > @@ -96,7 +96,6 @@ Enable the GCC plugin infrastructure and some plugin(s) you want to use
> > in the kernel config::
> >
> > CONFIG_GCC_PLUGINS=y
> > - CONFIG_GCC_PLUGIN_CYC_COMPLEXITY=y
> > CONFIG_GCC_PLUGIN_LATENT_ENTROPY=y
> > ...
> >
>
> There is a comment about the cyc_complexity plugin at the very end of
> this file that should also be removed it seems:
>
> "See the cyc_complexity_plugin.c (CONFIG_GCC_PLUGIN_CYC_COMPLEXITY) GCC plugin."
Yup; I think it was hiding from you, see here:
>
> > @@ -115,4 +114,3 @@ The GCC plugins are in scripts/gcc-plugins/. You need to put plugin source files
> > right under scripts/gcc-plugins/. Creating subdirectories is not supported.
> > It must be added to scripts/gcc-plugins/Makefile, scripts/Makefile.gcc-plugins
> > and a relevant Kconfig file.
> > -See the cyc_complexity_plugin.c (CONFIG_GCC_PLUGIN_CYC_COMPLEXITY) GCC plugin.
^^^^
:)
Thanks!
-Kees
--
Kees Cook
next prev parent reply other threads:[~2021-10-20 19:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 17:35 [PATCH 0/2] gcc-plugins: Explicitly document purpose and deprecation schedule Kees Cook
2021-10-20 17:35 ` [PATCH 1/2] " Kees Cook
2021-10-20 17:44 ` Miguel Ojeda
2021-10-20 19:12 ` Kees Cook
2021-10-20 17:45 ` Nathan Chancellor
2021-10-20 19:15 ` Kees Cook
2021-10-20 17:35 ` [PATCH 2/2] gcc-plugins: Remove cyc_complexity Kees Cook
2021-10-20 17:48 ` Miguel Ojeda
2021-10-20 19:11 ` Kees Cook
2021-10-20 17:48 ` Nathan Chancellor
2021-10-20 19:10 ` Kees Cook [this message]
2021-10-20 17:50 ` [PATCH 0/2] gcc-plugins: Explicitly document purpose and deprecation schedule Nick Desaulniers
2021-10-21 10:28 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110201209.A245EFB94@keescook \
--to=keescook@chromium.org \
--cc=ardb@kernel.org \
--cc=ashimida@linux.alibaba.com \
--cc=corbet@lwn.net \
--cc=jmorris@namei.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ojeda@kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).