From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3192C4332F for ; Wed, 20 Oct 2021 19:12:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9548F611B0 for ; Wed, 20 Oct 2021 19:12:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231490AbhJTTPD (ORCPT ); Wed, 20 Oct 2021 15:15:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231458AbhJTTPC (ORCPT ); Wed, 20 Oct 2021 15:15:02 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DBADC061755 for ; Wed, 20 Oct 2021 12:12:48 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id v8so3750846pfu.11 for ; Wed, 20 Oct 2021 12:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CFUDLBWdmnPV44bi7dVx5A56FXXnHIGNsm6BfJl0RsI=; b=JtQFBqmyuqUGLOJirZEnfOGRzSjyJfk76syhW8olBgTsaSJ1WrRnDKlU8xrvFkJEbB YZO0dY/VKA9+YDBXn7kwblGNLtajGRhaUcQJVIjGCA+DbxnLTaesnzOROD4lAa6oBXO3 ABy/6N42oUMuboWXbEo0EIYQPT+5a/NVcybC4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CFUDLBWdmnPV44bi7dVx5A56FXXnHIGNsm6BfJl0RsI=; b=Vd1n70iozXHMfkR9IiJfumnEFSpW56TnUvzavRMm6Wrbbr+zI5kW+iWfxUSDOeWPWs 9/QysSDi0kcee7hjPPoo7exN/1voAHc2lu0eSvvWN5f/wH4c6UD5iAzJNYOEU58a6IyP TQ2iZM4l/OsD45xzhuF3DvdQ1EWivq3YDlyS4T4jWT3yTVIBZy91lixbclHAhUf9yZnd eqOfMnUphEc5N9dIlElG0VgV9rsQFUKAm2KpTbglDZJiqnBRs/qlfwVaM8/4KB9sXncX UYLK4zRl6l0NCrZV1vxbFAAlzJ3BM6XVMbJBcPO65A3amgQlsVOVhIjvHPLnKr4RQH7s Kjsw== X-Gm-Message-State: AOAM530/kCXm34f/1Xp6H0SuyrxvqUpQZDFuBAzxIlb4QvRlirsNnetJ M635UDp4Wx9jMEULrtS6mTyDiA== X-Google-Smtp-Source: ABdhPJzl2+SAfUh6NkJ+DhCKOWmzKsU6GNvGxGf2XT0aJXU9P6UbVjWdBAkeh+PuF3DGKEHMZ/Xdaw== X-Received: by 2002:a63:4622:: with SMTP id t34mr814413pga.293.1634757167736; Wed, 20 Oct 2021 12:12:47 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id e9sm3758333pfv.189.2021.10.20.12.12.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Oct 2021 12:12:47 -0700 (PDT) Date: Wed, 20 Oct 2021 12:12:46 -0700 From: Kees Cook To: Miguel Ojeda Cc: Masahiro Yamada , Michal Marek , Nick Desaulniers , Jonathan Corbet , James Morris , "Serge E. Hallyn" , Nathan Chancellor , linux-hardening@vger.kernel.org, Linux Kbuild mailing list , Linux Doc Mailing List , linux-security-module , llvm@lists.linux.dev, Dan Li , Ard Biesheuvel , Miguel Ojeda , linux-kernel Subject: Re: [PATCH 1/2] gcc-plugins: Explicitly document purpose and deprecation schedule Message-ID: <202110201212.C155FE92@keescook> References: <20211020173554.38122-1-keescook@chromium.org> <20211020173554.38122-2-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: On Wed, Oct 20, 2021 at 07:44:19PM +0200, Miguel Ojeda wrote: > On Wed, Oct 20, 2021 at 7:35 PM Kees Cook wrote: > > > > +Purpose > > +======= > > Sounds good to me. > > > config GCC_PLUGIN_SANCOV > > bool > > + # Plugin can be removed once the kernel only supports GCC 6.1.0+ > > Since we are just giving the major in the other cases below, I would > just say GCC 6+ here (the numbering scheme changed in GCC 5 already). Sure; now updated. > Thanks for adding the versions, by the way -- this is useful long-term > and not always done for other things... Yeah, I always struggled to find when options were added to GCC, so I wanted this for my poor brain too. :) > Reviewed-by: Miguel Ojeda Thanks! -- Kees Cook