* [PATCH] evm: mark evm_fixmode as __ro_after_init
@ 2021-10-28 11:26 Austin Kim
2021-10-29 1:57 ` Mimi Zohar
0 siblings, 1 reply; 2+ messages in thread
From: Austin Kim @ 2021-10-28 11:26 UTC (permalink / raw)
To: zohar, jmorris, serge
Cc: linux-integrity, linux-security-module, linux-kernel, austin.kim
From: Austin Kim <austin.kim@lge.com>
The evm_fixmode is only configurable by command-line option and it is never
modified outside initcalls, so declaring it with __ro_after_init is better.
Signed-off-by: Austin Kim <austin.kim@lge.com>
---
security/integrity/evm/evm_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/integrity/evm/evm_main.c b/security/integrity/evm/evm_main.c
index 1c8435dfabee..08f907382c61 100644
--- a/security/integrity/evm/evm_main.c
+++ b/security/integrity/evm/evm_main.c
@@ -78,7 +78,7 @@ static struct xattr_list evm_config_default_xattrnames[] = {
LIST_HEAD(evm_config_xattrnames);
-static int evm_fixmode;
+static int evm_fixmode __ro_after_init;
static int __init evm_set_fixmode(char *str)
{
if (strncmp(str, "fix", 3) == 0)
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] evm: mark evm_fixmode as __ro_after_init
2021-10-28 11:26 [PATCH] evm: mark evm_fixmode as __ro_after_init Austin Kim
@ 2021-10-29 1:57 ` Mimi Zohar
0 siblings, 0 replies; 2+ messages in thread
From: Mimi Zohar @ 2021-10-29 1:57 UTC (permalink / raw)
To: Austin Kim, jmorris, serge
Cc: linux-integrity, linux-security-module, linux-kernel, austin.kim
On Thu, 2021-10-28 at 12:26 +0100, Austin Kim wrote:
> From: Austin Kim <austin.kim@lge.com>
>
> The evm_fixmode is only configurable by command-line option and it is never
> modified outside initcalls, so declaring it with __ro_after_init is better.
>
> Signed-off-by: Austin Kim <austin.kim@lge.com>
Thanks, Austin. This patch set is now applied to the next-integrity
branch.
Mimi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-29 1:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-28 11:26 [PATCH] evm: mark evm_fixmode as __ro_after_init Austin Kim
2021-10-29 1:57 ` Mimi Zohar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).