From: Austin Kim <austindh.kim@gmail.com>
To: mic@digikod.net, serge@hallyn.com
Cc: serge@hallyn.com, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, austindh.kim@gmail.com
Subject: [PATCH] landlock: Initialize kernel stack variables properly
Date: Wed, 3 Nov 2021 07:14:27 +0000 [thread overview]
Message-ID: <20211103071427.GA13854@raspberrypi> (raw)
In case kernel stack variables are not initialized properly, there might
be a little chance of kernel information disclosure. So it is better for
kernel stack variables to be initialized with null characters.
Signed-off-by: Austin Kim <austindh.kim@gmail.com>
---
security/landlock/syscalls.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/security/landlock/syscalls.c b/security/landlock/syscalls.c
index 32396962f04d..50a6f7091428 100644
--- a/security/landlock/syscalls.c
+++ b/security/landlock/syscalls.c
@@ -320,6 +320,8 @@ SYSCALL_DEFINE4(landlock_add_rule,
if (rule_type != LANDLOCK_RULE_PATH_BENEATH)
return -EINVAL;
+ memset(&path_beneath_attr, 0, sizeof(path_beneath_attr));
+
/* Copies raw user space buffer, only one type for now. */
res = copy_from_user(&path_beneath_attr, rule_attr,
sizeof(path_beneath_attr));
--
2.20.1
next reply other threads:[~2021-11-03 7:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 7:14 Austin Kim [this message]
2021-11-03 12:17 ` [PATCH] landlock: Initialize kernel stack variables properly Mickaël Salaün
2021-11-04 11:41 ` Austin Kim
2021-11-05 16:58 ` J Freyensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211103071427.GA13854@raspberrypi \
--to=austindh.kim@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).