linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] apparmor: remove duplicated 'Returns:' comments
@ 2021-11-03  9:25 Austin Kim
  2021-11-12  1:25 ` John Johansen
  0 siblings, 1 reply; 2+ messages in thread
From: Austin Kim @ 2021-11-03  9:25 UTC (permalink / raw)
  To: john.johansen, serge; +Cc: linux-security-module, linux-kernel, austindh.kim

It might look better if duplicated 'Returns:' comment is removed.

Signed-off-by: Austin Kim <austindh.kim@gmail.com>
---
 security/apparmor/procattr.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/security/apparmor/procattr.c b/security/apparmor/procattr.c
index c929bf4a3df1..fde332e0ea7d 100644
--- a/security/apparmor/procattr.c
+++ b/security/apparmor/procattr.c
@@ -21,8 +21,6 @@
  * @profile: the profile to print profile info about  (NOT NULL)
  * @string: Returns - string containing the profile info (NOT NULL)
  *
- * Returns: length of @string on success else error on failure
- *
  * Requires: profile != NULL
  *
  * Creates a string containing the namespace_name://profile_name for
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] apparmor: remove duplicated 'Returns:' comments
  2021-11-03  9:25 [PATCH] apparmor: remove duplicated 'Returns:' comments Austin Kim
@ 2021-11-12  1:25 ` John Johansen
  0 siblings, 0 replies; 2+ messages in thread
From: John Johansen @ 2021-11-12  1:25 UTC (permalink / raw)
  To: Austin Kim, serge; +Cc: linux-security-module, linux-kernel

On 11/3/21 2:25 AM, Austin Kim wrote:
> It might look better if duplicated 'Returns:' comment is removed.
> 
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>

sorry, it looks like I forgot to reply to this. I pulled this into the
apparmor tree and it has been merged for 5.16

> ---
>  security/apparmor/procattr.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/security/apparmor/procattr.c b/security/apparmor/procattr.c
> index c929bf4a3df1..fde332e0ea7d 100644
> --- a/security/apparmor/procattr.c
> +++ b/security/apparmor/procattr.c
> @@ -21,8 +21,6 @@
>   * @profile: the profile to print profile info about  (NOT NULL)
>   * @string: Returns - string containing the profile info (NOT NULL)
>   *
> - * Returns: length of @string on success else error on failure
> - *
>   * Requires: profile != NULL
>   *
>   * Creates a string containing the namespace_name://profile_name for
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-12  1:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-03  9:25 [PATCH] apparmor: remove duplicated 'Returns:' comments Austin Kim
2021-11-12  1:25 ` John Johansen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).