From: Christian Brauner <brauner@kernel.org>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: Paul Moore <paul@paul-moore.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
Christian Brauner <christian@brauner.io>,
James Morris <jmorris@namei.org>,
Linux Security Module list
<linux-security-module@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
syzbot <syzbot+d1e3b1d92d25abf97943@syzkaller.appspotmail.com>,
David Howells <dhowells@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
selinux@vger.kernel.org
Subject: Re: [PATCH v2] LSM: general protection fault in legacy_parse_param
Date: Fri, 28 Jan 2022 09:59:14 +0100 [thread overview]
Message-ID: <20220128085914.rxrz7qt3uk7fp67d@wittgenstein> (raw)
In-Reply-To: <a19e0338-5240-4a6d-aecf-145539aecbce@schaufler-ca.com>
On Thu, Jan 27, 2022 at 08:51:44AM -0800, Casey Schaufler wrote:
> The usual LSM hook "bail on fail" scheme doesn't work for cases where
> a security module may return an error code indicating that it does not
> recognize an input. In this particular case Smack sees a mount option
> that it recognizes, and returns 0. A call to a BPF hook follows, which
> returns -ENOPARAM, which confuses the caller because Smack has processed
> its data.
>
> The SELinux hook incorrectly returns 1 on success. There was a time
> when this was correct, however the current expectation is that it
> return 0 on success. This is repaired.
>
> Reported-by: syzbot+d1e3b1d92d25abf97943@syzkaller.appspotmail.com
> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
> ---
Looks good,
Acked-by: Christian Brauner <brauner@kernel.org>
prev parent reply other threads:[~2022-01-28 8:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <018a9bb4-accb-c19a-5b0a-fde22f4bc822.ref@schaufler-ca.com>
2021-10-11 22:40 ` [PATCH] LSM: general protection fault in legacy_parse_param Casey Schaufler
2021-10-12 10:32 ` Christian Brauner
2021-10-12 14:27 ` Casey Schaufler
2022-01-25 22:18 ` Paul Moore
2022-01-25 23:30 ` Casey Schaufler
2022-01-25 23:36 ` Paul Moore
2022-01-26 7:24 ` Christian Brauner
2022-01-26 22:37 ` Paul Moore
2022-01-27 16:51 ` [PATCH v2] " Casey Schaufler
2022-01-27 17:33 ` James Morris
2022-01-28 1:44 ` Paul Moore
2022-01-28 2:33 ` Casey Schaufler
2022-01-28 8:59 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220128085914.rxrz7qt3uk7fp67d@wittgenstein \
--to=brauner@kernel.org \
--cc=casey@schaufler-ca.com \
--cc=christian.brauner@ubuntu.com \
--cc=christian@brauner.io \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=syzbot+d1e3b1d92d25abf97943@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox