From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Philipp Reisner <philipp.reisner@linbit.com>,
Kees Cook <keescook@chromium.org>,
linux-block@vger.kernel.org, drbd-dev@lists.linbit.com,
linux-security-module@vger.kernel.org
Subject: [PATCH 3/5] block: stop using bdevname in drbd_report_io_error
Date: Thu, 3 Mar 2022 14:32:21 +0300 [thread overview]
Message-ID: <20220303113223.326220-4-hch@lst.de> (raw)
In-Reply-To: <20220303113223.326220-1-hch@lst.de>
Use the %pg format specifier to save on stack consuption and code size.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/block/drbd/drbd_req.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c
index c00ae8619519e..82a9adb7d55ce 100644
--- a/drivers/block/drbd/drbd_req.c
+++ b/drivers/block/drbd/drbd_req.c
@@ -511,16 +511,14 @@ static void mod_rq_state(struct drbd_request *req, struct bio_and_error *m,
static void drbd_report_io_error(struct drbd_device *device, struct drbd_request *req)
{
- char b[BDEVNAME_SIZE];
-
if (!__ratelimit(&drbd_ratelimit_state))
return;
- drbd_warn(device, "local %s IO error sector %llu+%u on %s\n",
+ drbd_warn(device, "local %s IO error sector %llu+%u on %pg\n",
(req->rq_state & RQ_WRITE) ? "WRITE" : "READ",
(unsigned long long)req->i.sector,
req->i.size >> 9,
- bdevname(device->ldev->backing_bdev, b));
+ device->ldev->backing_bdev);
}
/* Helper for HANDED_OVER_TO_NETWORK.
--
2.30.2
next prev parent reply other threads:[~2022-03-03 11:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 11:32 a few trivial bdevname() removals Christoph Hellwig
2022-03-03 11:32 ` [PATCH 1/5] block: stop using bdevname in bdev_write_inode Christoph Hellwig
2022-03-03 15:33 ` Johannes Thumshirn
2022-03-03 11:32 ` [PATCH 2/5] block: stop using bdevname in __blkdev_issue_discard Christoph Hellwig
2022-03-03 15:34 ` Johannes Thumshirn
2022-03-03 11:32 ` Christoph Hellwig [this message]
2022-03-03 15:34 ` [PATCH 3/5] block: stop using bdevname in drbd_report_io_error Johannes Thumshirn
2022-03-03 11:32 ` [PATCH 4/5] pktcdvd: stop using bdevname Christoph Hellwig
2022-03-03 15:34 ` Johannes Thumshirn
2022-03-03 11:32 ` [PATCH 5/5] loadpin: " Christoph Hellwig
2022-03-03 15:35 ` Johannes Thumshirn
2022-03-03 17:29 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220303113223.326220-4-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=keescook@chromium.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).