From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DDEEC43219 for ; Tue, 10 May 2022 15:59:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346900AbiEJQDd (ORCPT ); Tue, 10 May 2022 12:03:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346995AbiEJQBB (ORCPT ); Tue, 10 May 2022 12:01:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B358B3CA52; Tue, 10 May 2022 08:53:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4284961673; Tue, 10 May 2022 15:53:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C17F4C385A6; Tue, 10 May 2022 15:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652198019; bh=9pgUcC73MMhE3nPFiSsB/Zp0JFryDLtpwGsW8VKXMIc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u7AzoJ/Wk3+3/R2dR6hL3nO2cRTFVkpejdusu1cWWqVxNKpzc9Vy/meXirezGrwZi J0ZEbm2n4fxpjjgMY/pmT/vd2Mfu9pcKIxWKj95uWzWf40AodLu8S0c6nIM19gJ0Tw kSXcRleqg5eBZ5f/7ks7y1nufYS4P6+8qpjb9XOe0fmD6kocBMMPPBx+gDCifjtF1z 2Zp/8QdJFjY+q9EAns9A3uZUD9ZctwxPKJN+UbTg8PKs6esQzU2pPpusSbNwm8Am3L tgGo6JPSNRMoETWilBHweh5lLCuzXFJFNFzTyG3qS4ZYm5/zyhCRYffXVvbjjgP0Br uc7+JMwnO6kow== Date: Tue, 10 May 2022 17:53:32 +0200 From: Christian Brauner To: Miklos Szeredi Cc: linux-fsdevel@vger.kernel.org, Dave Chinner , Theodore Ts'o , Karel Zak , Greg KH , linux-kernel@vger.kernel.org, Linux API , linux-man , LSM , Ian Kent , David Howells , Linus Torvalds , Al Viro , Christian Brauner , Amir Goldstein , James Bottomley Subject: Re: [RFC PATCH] getting misc stats/attributes via xattr API Message-ID: <20220510155332.3zm5nycl7nmuxgdx@wittgenstein> References: <20220509124815.vb7d2xj5idhb2wq6@wittgenstein> <20220510115316.acr6gl5ayqszada6@wittgenstein> <20220510141932.lth3bryefbl6ykny@wittgenstein> <20220510153050.cgbt3wezbvf2jfnb@wittgenstein> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: On Tue, May 10, 2022 at 05:47:13PM +0200, Miklos Szeredi wrote: > On Tue, 10 May 2022 at 17:30, Christian Brauner wrote: > > > But now we're in the process of extending the *xattr() calls to operate > > on mounts and filesystems so an additional getfsattr() (or another name) > > is not fragmentation imho. And I definitely don't think this would > > qualify as "crazy". > > In that spirit st_dev does not belong in struct stat, because that is > the property of the block device, not the inode. > > But I feel we are going round in circles, lets please not get hung up > on this issue. Linus will have the final word on which variant (if > either) is going to go in. Well yes, I'm obviously not going to be d*ck about it and go around NAKing it just because I didn't get my favorite name but I at least want to register my strong opposition to the current "unification" approach loud and clear. :)