linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Casey Schaufler <casey@schaufler-ca.com>,
	casey.schaufler@intel.com, jmorris@namei.org,
	linux-security-module@vger.kernel.org, selinux@vger.kernel.org
Cc: kbuild-all@lists.01.org, casey@schaufler-ca.com,
	linux-audit@redhat.com, keescook@chromium.org,
	john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp,
	paul@paul-moore.com, stephen.smalley.work@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v36 18/33] LSM: Use lsmcontext in security_dentry_init_security
Date: Fri, 10 Jun 2022 11:05:21 +0800	[thread overview]
Message-ID: <202206101053.7FemxCmO-lkp@intel.com> (raw)
In-Reply-To: <20220609230146.319210-19-casey@schaufler-ca.com>

Hi Casey,

I love your patch! Perhaps something to improve:

[auto build test WARNING on pcmoore-audit/next]
[also build test WARNING on pcmoore-selinux/next linus/master]
[cannot apply to jmorris-security/next-testing]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Casey-Schaufler/integrity-disassociate-ima_filter_rule-from-security_audit_rule/20220610-080129
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pcmoore/audit.git next
config: s390-randconfig-r044-20220608 (https://download.01.org/0day-ci/archive/20220610/202206101053.7FemxCmO-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/86d33e271bed739fe32367e703b054ea253bb471
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Casey-Schaufler/integrity-disassociate-ima_filter_rule-from-security_audit_rule/20220610-080129
        git checkout 86d33e271bed739fe32367e703b054ea253bb471
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash fs/fuse/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/build_bug.h:5,
                    from include/linux/container_of.h:5,
                    from include/linux/list.h:5,
                    from include/linux/wait.h:7,
                    from include/linux/wait_bit.h:8,
                    from include/linux/fs.h:6,
                    from fs/fuse/fuse_i.h:17,
                    from fs/fuse/dir.c:9:
   fs/fuse/dir.c: In function 'get_security_context.constprop':
>> include/linux/compiler.h:70:46: warning: 'lsmctx.len' is used uninitialized [-Wuninitialized]
      70 |                 (__if_trace.miss_hit[1]++,1) :          \
         |                                              ^
   fs/fuse/dir.c:467:27: note: 'lsmctx.len' was declared here
     467 |         struct lsmcontext lsmctx;
         |                           ^~~~~~


vim +70 include/linux/compiler.h

a15fd609ad53a6 Linus Torvalds 2019-03-20  59  
a15fd609ad53a6 Linus Torvalds 2019-03-20  60  #define __trace_if_value(cond) ({			\
2bcd521a684cc9 Steven Rostedt 2008-11-21  61  	static struct ftrace_branch_data		\
e04462fb82f8dd Miguel Ojeda   2018-09-03  62  		__aligned(4)				\
33def8498fdde1 Joe Perches    2020-10-21  63  		__section("_ftrace_branch")		\
a15fd609ad53a6 Linus Torvalds 2019-03-20  64  		__if_trace = {				\
2bcd521a684cc9 Steven Rostedt 2008-11-21  65  			.func = __func__,		\
2bcd521a684cc9 Steven Rostedt 2008-11-21  66  			.file = __FILE__,		\
2bcd521a684cc9 Steven Rostedt 2008-11-21  67  			.line = __LINE__,		\
2bcd521a684cc9 Steven Rostedt 2008-11-21  68  		};					\
a15fd609ad53a6 Linus Torvalds 2019-03-20  69  	(cond) ?					\
a15fd609ad53a6 Linus Torvalds 2019-03-20 @70  		(__if_trace.miss_hit[1]++,1) :		\
a15fd609ad53a6 Linus Torvalds 2019-03-20  71  		(__if_trace.miss_hit[0]++,0);		\
a15fd609ad53a6 Linus Torvalds 2019-03-20  72  })
a15fd609ad53a6 Linus Torvalds 2019-03-20  73  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

  reply	other threads:[~2022-06-10  3:06 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220609230146.319210-1-casey.ref@schaufler-ca.com>
2022-06-09 23:01 ` [PATCH v36 00/33] LSM: Module stacking for AppArmor Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 01/33] integrity: disassociate ima_filter_rule from security_audit_rule Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 02/33] LSM: Infrastructure management of the sock security Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 03/33] LSM: Add the lsmblob data structure Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 04/33] LSM: provide lsm name and id slot mappings Casey Schaufler
2022-06-10  7:51     ` kernel test robot
2022-06-09 23:01   ` [PATCH v36 05/33] IMA: avoid label collisions with stacked LSMs Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 06/33] LSM: Use lsmblob in security_audit_rule_match Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 07/33] LSM: Use lsmblob in security_kernel_act_as Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 08/33] LSM: Use lsmblob in security_secctx_to_secid Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 09/33] LSM: Use lsmblob in security_secid_to_secctx Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 10/33] LSM: Use lsmblob in security_ipc_getsecid Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 11/33] LSM: Use lsmblob in security_current_getsecid Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 12/33] LSM: Use lsmblob in security_inode_getsecid Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 13/33] LSM: Use lsmblob in security_cred_getsecid Casey Schaufler
2022-06-12 19:35     ` kernel test robot
2022-06-09 23:01   ` [PATCH v36 14/33] LSM: Specify which LSM to display Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 15/33] LSM: Ensure the correct LSM context releaser Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 16/33] LSM: Use lsmcontext in security_secid_to_secctx Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 17/33] LSM: Use lsmcontext in security_inode_getsecctx Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 18/33] LSM: Use lsmcontext in security_dentry_init_security Casey Schaufler
2022-06-10  3:05     ` kernel test robot [this message]
2022-06-23  7:09     ` Dan Carpenter
2022-06-09 23:01   ` [PATCH v36 19/33] LSM: security_secid_to_secctx in netlink netfilter Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 20/33] NET: Store LSM netlabel data in a lsmblob Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 21/33] binder: Pass LSM identifier for confirmation Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 22/33] LSM: Extend security_secid_to_secctx to include module selection Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 23/33] Audit: Keep multiple LSM data in audit_names Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 24/33] Audit: Create audit_stamp structure Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 25/33] LSM: Add a function to report multiple LSMs Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 26/33] Audit: Allow multiple records in an audit_buffer Casey Schaufler
2022-06-10 21:04     ` Paul Moore
2022-06-09 23:01   ` [PATCH v36 27/33] Audit: Add record for multiple task security contexts Casey Schaufler
2022-06-10 21:06     ` Paul Moore
2022-06-09 23:01   ` [PATCH v36 28/33] audit: multiple subject lsm values for netlabel Casey Schaufler
2022-06-10 21:10     ` Paul Moore
2022-06-09 23:01   ` [PATCH v36 29/33] Audit: Add record for multiple object contexts Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 30/33] netlabel: Use a struct lsmblob in audit data Casey Schaufler
2022-06-10 21:12     ` Paul Moore
2022-06-09 23:01   ` [PATCH v36 31/33] LSM: Removed scaffolding function lsmcontext_init Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 32/33] LSM: Add /proc attr entry for full LSM context Casey Schaufler
2022-06-09 23:01   ` [PATCH v36 33/33] AppArmor: Remove the exclusive flag Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202206101053.7FemxCmO-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=casey.schaufler@intel.com \
    --cc=casey@schaufler-ca.com \
    --cc=jmorris@namei.org \
    --cc=john.johansen@canonical.com \
    --cc=kbuild-all@lists.01.org \
    --cc=keescook@chromium.org \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=selinux@vger.kernel.org \
    --cc=stephen.smalley.work@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).