* [PATCH] KEYS: Variable type completion
@ 2022-08-16 18:01 Xin Gao
2022-08-16 18:14 ` Al Viro
0 siblings, 1 reply; 3+ messages in thread
From: Xin Gao @ 2022-08-16 18:01 UTC (permalink / raw)
To: dhowells, jarkko
Cc: jmorris, serge, keyrings, linux-security-module, linux-kernel,
Xin Gao
'unsigned int' is better than 'unsigned'.
Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
---
security/keys/keyctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/keys/keyctl.c b/security/keys/keyctl.c
index 96a92a645216..4564505e7594 100644
--- a/security/keys/keyctl.c
+++ b/security/keys/keyctl.c
@@ -44,7 +44,7 @@ static const unsigned char keyrings_capabilities[2] = {
static int key_get_type_from_user(char *type,
const char __user *_type,
- unsigned len)
+ unsigned int len)
{
int ret;
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] keys: Variable type completion
@ 2022-08-16 18:04 Xin Gao
0 siblings, 0 replies; 3+ messages in thread
From: Xin Gao @ 2022-08-16 18:04 UTC (permalink / raw)
To: dhowells, jarkko
Cc: jmorris, serge, keyrings, linux-security-module, linux-kernel,
Xin Gao
'unsigned int' is better than 'unsigned'.
Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
---
security/keys/gc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/keys/gc.c b/security/keys/gc.c
index 3c90807476eb..433a96e26930 100644
--- a/security/keys/gc.c
+++ b/security/keys/gc.c
@@ -13,7 +13,7 @@
/*
* Delay between key revocation/expiry in seconds
*/
-unsigned key_gc_delay = 5 * 60;
+unsigned int key_gc_delay = 5 * 60;
/*
* Reaper for unused keys.
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] KEYS: Variable type completion
2022-08-16 18:01 [PATCH] KEYS: " Xin Gao
@ 2022-08-16 18:14 ` Al Viro
0 siblings, 0 replies; 3+ messages in thread
From: Al Viro @ 2022-08-16 18:14 UTC (permalink / raw)
To: Xin Gao
Cc: dhowells, jarkko, jmorris, serge, keyrings, linux-security-module,
linux-kernel
On Wed, Aug 17, 2022 at 02:01:10AM +0800, Xin Gao wrote:
> 'unsigned int' is better than 'unsigned'.
Explain.
You keep sending rather pointless patches with declarative
commit messages instead of explanations. Why is 'unsigned
int' better than 'unsigned'? Demonstrate understanding -
simple reference to checkpatch.pl does *NOT* count.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-16 18:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-16 18:04 [PATCH] keys: Variable type completion Xin Gao
-- strict thread matches above, loose matches on Subject: below --
2022-08-16 18:01 [PATCH] KEYS: " Xin Gao
2022-08-16 18:14 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).