* [PATCH] security: move from strlcpy with unused retval to strscpy
@ 2022-08-18 21:02 Wolfram Sang
2022-08-26 6:16 ` Jarkko Sakkinen
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2022-08-18 21:02 UTC (permalink / raw)
To: linux-kernel
Cc: Wolfram Sang, David Howells, Jarkko Sakkinen, Paul Moore,
James Morris, Serge E. Hallyn, keyrings, linux-security-module
Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.
Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
security/keys/request_key_auth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/keys/request_key_auth.c b/security/keys/request_key_auth.c
index 41e9735006d0..8f33cd170e42 100644
--- a/security/keys/request_key_auth.c
+++ b/security/keys/request_key_auth.c
@@ -178,7 +178,7 @@ struct key *request_key_auth_new(struct key *target, const char *op,
if (!rka->callout_info)
goto error_free_rka;
rka->callout_len = callout_len;
- strlcpy(rka->op, op, sizeof(rka->op));
+ strscpy(rka->op, op, sizeof(rka->op));
/* see if the calling process is already servicing the key request of
* another process */
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] security: move from strlcpy with unused retval to strscpy
2022-08-18 21:02 [PATCH] security: move from strlcpy with unused retval to strscpy Wolfram Sang
@ 2022-08-26 6:16 ` Jarkko Sakkinen
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Sakkinen @ 2022-08-26 6:16 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-kernel, David Howells, Paul Moore, James Morris,
Serge E. Hallyn, keyrings, linux-security-module
On Thu, Aug 18, 2022 at 11:02:31PM +0200, Wolfram Sang wrote:
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> security/keys/request_key_auth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/keys/request_key_auth.c b/security/keys/request_key_auth.c
> index 41e9735006d0..8f33cd170e42 100644
> --- a/security/keys/request_key_auth.c
> +++ b/security/keys/request_key_auth.c
> @@ -178,7 +178,7 @@ struct key *request_key_auth_new(struct key *target, const char *op,
> if (!rka->callout_info)
> goto error_free_rka;
> rka->callout_len = callout_len;
> - strlcpy(rka->op, op, sizeof(rka->op));
> + strscpy(rka->op, op, sizeof(rka->op));
>
> /* see if the calling process is already servicing the key request of
> * another process */
> --
> 2.35.1
>
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-26 6:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-18 21:02 [PATCH] security: move from strlcpy with unused retval to strscpy Wolfram Sang
2022-08-26 6:16 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).