From: "Serge E. Hallyn" <serge@hallyn.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-security-module@vger.kernel.org,
syzbot <syzbot+541e21dcc32c4046cba9@syzkaller.appspotmail.com>,
syzkaller-bugs@googlegroups.com,
Seth Forshee <sforshee@kernel.org>
Subject: Re: [PATCH (urgent)] vfs: fix uninitialized uid/gid in chown_common()
Date: Mon, 19 Sep 2022 18:41:02 -0500 [thread overview]
Message-ID: <20220919234102.GA21118@mail.hallyn.com> (raw)
In-Reply-To: <20220919151414.excah6gywyposvfj@wittgenstein>
On Mon, Sep 19, 2022 at 05:14:14PM +0200, Christian Brauner wrote:
> On Mon, Sep 19, 2022 at 05:12:25PM +0200, Christian Brauner wrote:
> > On Mon, Sep 19, 2022 at 08:05:12PM +0900, Tetsuo Handa wrote:
> > > syzbot is reporting uninit-value in tomoyo_path_chown() [1], for
> > > chown_common() is by error passing uninitialized newattrs.ia_vfsuid to
> > > security_path_chown() via from_vfsuid() when user == -1 is passed.
> > > We must initialize newattrs.ia_vfs{u,g}id fields in order to make
> > > from_vfs{u,g}id() work.
> > >
> > > Link: https://syzkaller.appspot.com/bug?extid=541e21dcc32c4046cba9 [1]
> > > Reported-by: syzbot <syzbot+541e21dcc32c4046cba9@syzkaller.appspotmail.com>
> > > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> > > ---
> >
> > Odd that we didn't get any of the reports. Thanks for relying this.
> > I'll massage this a tiny bit, apply and will test with syzbot.
>
> Fyi, Seth.
Because the modules are ignoring ia_valid & ATTR_XID?
next prev parent reply other threads:[~2022-09-19 23:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 8:10 [syzbot] KMSAN: uninit-value in tomoyo_path_chown syzbot
2022-09-19 11:05 ` [PATCH (urgent)] vfs: fix uninitialized uid/gid in chown_common() Tetsuo Handa
2022-09-19 15:12 ` Christian Brauner
2022-09-19 15:14 ` Christian Brauner
2022-09-19 23:41 ` Serge E. Hallyn [this message]
2022-09-20 0:25 ` Seth Forshee
2022-09-20 0:29 ` Seth Forshee
2022-09-20 0:45 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220919234102.GA21118@mail.hallyn.com \
--to=serge@hallyn.com \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=sforshee@kernel.org \
--cc=syzbot+541e21dcc32c4046cba9@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).