From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CFCEC43219 for ; Fri, 14 Oct 2022 17:59:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229827AbiJNR7s (ORCPT ); Fri, 14 Oct 2022 13:59:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229894AbiJNR7q (ORCPT ); Fri, 14 Oct 2022 13:59:46 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A9255F5F for ; Fri, 14 Oct 2022 10:59:38 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id t12-20020a17090a3b4c00b0020b04251529so5405028pjf.5 for ; Fri, 14 Oct 2022 10:59:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=lIA5kCd21RHEnMbxdNImt2sQ/3g725z4r3mMj6tBAeg=; b=hfa/QWPjWqnauRAj8LTTvkLH8F/ZfZmIPDY/huHYxu5usQnH2THr+sGzN/cWVm8Hg4 hi3JZA4hN2jg9g1okYOWDiwT/CAMzepro+6AZLKfW7vNz8Rp+A8Q9bPaTIzbcberVsYN 2A0sqgFqWi0uCLu/Ii+aL2/kLXUD86KYe2af4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lIA5kCd21RHEnMbxdNImt2sQ/3g725z4r3mMj6tBAeg=; b=h7edoaOqOuJFKdQ/MyyINxX/LurFObrSd8aiBGQovmzUbIdtX5eE+ZRJp8cFFf+zyT 14uoRPSXrTS1OX4RUIGzMZmsACHLZMWjnkMHROcEyTda3wuq4+iS21fH0hnGkNXbwSgF 5yHU9LY/tWfSBmtPmKki8xQWmCHXLHzeaVikW26fbMkaQd0/OFNgW5kfiXc82fD19bVM 2J4t1yax2TUeIaj5EYs5avxN3/vPlA0+xX0MdGo+XVCiuihyiQY+Vi4aU/jgo6en0kSs GkdKtnEkjYtod8zRJuECylxajjKcnYkf2ZP5c6+BI+c7uj9n00MwgqzcbQAjqzggdKC4 JHHQ== X-Gm-Message-State: ACrzQf3MDlEfDtlUFeG2pRaoXH9trbQKDQxN+s5bSFrYlc9eIibqIXD6 X7ogxDOqRn9D5zHWOSYafoYs9g== X-Google-Smtp-Source: AMsMyM4TRh2gr+kOS0rnlcc/KQKS33NEffPf3pWG7t7imgdj7HB2jOO7UNnIZR4eUJsSLYpCw3FUVA== X-Received: by 2002:a17:90b:3d8:b0:20a:8e90:8e8c with SMTP id go24-20020a17090b03d800b0020a8e908e8cmr6907001pjb.138.1665770377827; Fri, 14 Oct 2022 10:59:37 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w11-20020a170902ca0b00b0017f7fa6808csm2015707pld.87.2022.10.14.10.59.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Oct 2022 10:59:36 -0700 (PDT) Date: Fri, 14 Oct 2022 10:59:35 -0700 From: Kees Cook To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: Mimi Zohar , Paul Moore , James Morris , "Serge E. Hallyn" , Dmitry Kasatkin , linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, KP Singh , Casey Schaufler , John Johansen , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 1/9] integrity: Prepare for having "ima" and "evm" available in "integrity" LSM Message-ID: <202210141050.A8DF7D10@keescook> References: <20221013222702.never.990-kees@kernel.org> <20221013223654.659758-1-keescook@chromium.org> <08a8b202-69b4-e154-28f5-337a898acf61@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <08a8b202-69b4-e154-28f5-337a898acf61@digikod.net> Precedence: bulk List-ID: On Fri, Oct 14, 2022 at 04:40:01PM +0200, Mickaël Salaün wrote: > This is not backward compatible Why? Nothing will be running LSM hooks until init finishes, at which point the integrity inode cache will be allocated. And ima and evm don't start up until lateinit. >, but can easily be fixed thanks to > DEFINE_LSM().order That forces the LSM to be enabled, which may not be desired? > Side node: I proposed an alternative to that but it was Nacked: > https://lore.kernel.org/all/20210222150608.808146-1-mic@digikod.net/ Yeah, for the reasons pointed out -- that can't work. The point is to not have The Default LSM. I do think Casey's NAK was rather prickly, though. ;) -- Kees Cook